Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpSessionState.Mode #289

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Add HttpSessionState.Mode #289

merged 3 commits into from
Feb 17, 2023

Conversation

twsouthwick
Copy link
Member

@twsouthwick twsouthwick commented Feb 14, 2023

This change exposes the API and sets it to Custom. Everything else has a meaning and implies certain behavior. This value is the only one that makes sense for us to declare. If needed later we can make it customizeable.

Fixes #281

@twsouthwick
Copy link
Member Author

@Tratcher We had talked about creating an option to enable this, but this ties it to the ISessionManager implementation with a default interface method. Thoughts?

@twsouthwick
Copy link
Member Author

After chatting with @mjrousos we decided that the value Customize was the only one that made sense for now.

Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hence the original idea to make it configurable so it would say whatever they needed it to say, but this is adequate for now.

@twsouthwick twsouthwick merged commit aa73002 into main Feb 17, 2023
@twsouthwick twsouthwick deleted the tasou/session-mode branch February 17, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing API: HttpSessionState.Mode
2 participants