-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browser launch regex to support non-default logging frameworks #3842
Conversation
this regex only works with the default logging system. If you change the output template with something like serilog or another logging framework the regex will not match. Loosening it up to match this text will work in more cases.
@steveoh You are just changing the documentation. Did you mean to change the default regex that the templates output also? |
@gregg-miskelly i cant find the template file. So this is still only docs. Link me if you would like me to update it there also. |
Here are the other spots:
|
please dble check this one, there are too many escape characters so I just guessed.
ok @gregg-miskelly please review those crazy escape sequence and let me know if i fouled it up. |
I will give it a quick test, but I think you have that right. |
Looks like you want to change the package.json line to : |
Ok, i made that change. Hopefully that's everything but if not I gave you access to edit my branch. Thanks! |
Thanks for fixing this! |
this regex only works with the default logging system. If you change the output template with something like serilog or another logging framework the regex will not match. Loosening it up to match this text will work in more cases.