Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Razor packages #4067

Merged
merged 3 commits into from
Sep 15, 2020
Merged

Conversation

ajaybhargavb
Copy link
Contributor

Includes bug fixes for Razor formatting

@NTaylorMullen @ryanbrandenburg @TanayParikh

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the version change Taylor pointed out.

@ajaybhargavb
Copy link
Contributor Author

Updated. Also verified everything works fine locally.
@JoeRobich could you update the release?

@TanayParikh
Copy link
Contributor

@ajaybhargavb CIs' failing, looks like it's expecting changes in the package.lock.json.

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #4067 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4067   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          60       60           
  Lines        1856     1856           
  Branches      214      214           
=======================================
  Hits         1596     1596           
  Misses        200      200           
  Partials       60       60           
Flag Coverage Δ
#integration ?
#unit 85.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46fb48c...9312d1b. Read the comment docs.

@ajaybhargavb
Copy link
Contributor Author

cc @nohwnd

@JoeRobich JoeRobich merged commit 797eecc into dotnet:master Sep 15, 2020
@JoeRobich
Copy link
Member

@ajaybhargavb New beta https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.3-beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants