Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ListView control UIA accessibility #3224

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Adding ListView control UIA accessibility #3224

merged 3 commits into from
Aug 12, 2020

Conversation

M-Lipin
Copy link
Contributor

@M-Lipin M-Lipin commented May 5, 2020 •
edited
Loading

Implementing UIA for ListView control.
Moving ListView accessible objects to separate files.

Fixes #3223

Proposed changes

  • Adding UIA accessibility support for ListView control.
  • Moving ListView accessibility to separate files.

Customer Impact

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

image

After

image

Test methodology

  • Manual testing.
  • Unit tests.
  • Automation tests.

Accessibility testing

Test environment(s)

.NET Core 5.0
Version: 5.0.100-alpha.1.20073.10
Commit: 29f4d693a9
Runtime Environment:
OS Name: Windows
OS Version: 10.0.18363
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\5.0.100-alpha1-05536
Host (useful for support):
Version: 5.0.0-alpha.1.20072.3
Commit: c3dc1fdfdc

Microsoft Reviewers: Open in CodeFlow

@M-Lipin M-Lipin requested a review from a team as a code owner May 5, 2020 21:15
@ghost ghost assigned M-Lipin May 5, 2020
RussKie
RussKie requested changes May 6, 2020
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but there is a room for improvement.
I also want to see tests, especially those that verify we don't create handles.

src/System.Windows.Forms/src/Resources/SR.resx Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/AccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewColumnAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
@ghost ghost added the 📭 waiting-author-feedback The team requires more information from the author label May 6, 2020
@RussKie RussKie marked this pull request as draft May 6, 2020 05:41
@M-Lipin M-Lipin changed the title Adding MultipleView UIA pattern support to WinForms. Adding ListView control UIA accessibility May 6, 2020
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label May 6, 2020
weltkante
weltkante suggested changes May 6, 2020
View reviewed changes
Copy link
Contributor

@weltkante weltkante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ComVisible on classes should only be needed if you want to call the default constructor from COM. Just passing a .NET object to COM always worked without this attribute for me.

If you want ComVisible(true) to actually work you need a GUID and some sort of registration with COM. You have to make sure you use newly generated GUIDs to not conflict with existing classes from Desktop Framework.

src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewItemAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewSubItemAccessibleObject.cs Outdated Show resolved Hide resolved
@ghost ghost added 📭 waiting-author-feedback The team requires more information from the author and removed 📭 waiting-author-feedback The team requires more information from the author labels May 6, 2020
@M-Lipin M-Lipin force-pushed the Issue_3223_ListView_UIA_Accessibility branch from 0cab869 to 7380a5a Compare May 12, 2020 21:14
@M-Lipin
Copy link
Contributor Author

M-Lipin commented May 12, 2020

At this moment working on adding accessibility for ListViewGroups and unit tests.

RussKie
RussKie requested changes May 19, 2020
View reviewed changes
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/InternalAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/AccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/InternalAccessibleObject.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewItemAccessibleObject.cs Outdated Show resolved Hide resolved
@ghost ghost added the 📭 waiting-author-feedback The team requires more information from the author label May 19, 2020
@RussKie
Copy link
Member

RussKie commented May 19, 2020

@M-Lipin @Ryuugamine internal API keep proliferating. Before we added them for test access purposes, however we should be reducing these numbers.
For all new API please verify and confirm internal is indeed necessary access level. If not, reduce the visibility.

@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label May 20, 2020
@Ryuugamine Ryuugamine force-pushed the Issue_3223_ListView_UIA_Accessibility branch 2 times, most recently from 43f9179 to 481bf13 Compare August 11, 2020 13:22
@RussKie
Copy link
Member

RussKie commented Aug 12, 2020

/azp run

@dotnet dotnet deleted a comment from codecov bot Aug 12, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

RussKie
RussKie reviewed Aug 12, 2020
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

src/System.Windows.Forms/src/System/Windows/Forms/ListView.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListView.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListViewGroup.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListViewGroup.cs Outdated Show resolved Hide resolved
...rms/src/System/Windows/Forms/ListViewItem.ListViewSubItem.ListViewSubItemAccessibleObject.cs Outdated Show resolved Hide resolved
...rms/tests/UnitTests/System/Windows/Forms/ListViewGroup.ListViewGroupAccessibleObjectTests.cs Outdated Show resolved Hide resolved
...ts/System/Windows/Forms/ListViewItem.ListViewSubItem.ListViewSubItemAccessibleObjectTests.cs Show resolved Hide resolved
@Ryuugamine Ryuugamine force-pushed the Issue_3223_ListView_UIA_Accessibility branch from 481bf13 to 00e523c Compare August 12, 2020 09:26
@Ryuugamine Ryuugamine removed the 📭 waiting-author-feedback The team requires more information from the author label Aug 12, 2020
@Ryuugamine Ryuugamine force-pushed the Issue_3223_ListView_UIA_Accessibility branch from 00e523c to 85330c4 Compare August 12, 2020 09:34
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #3224 into master will decrease coverage by 31.31202%.
The diff coverage is 60.94571%.

@@                 Coverage Diff                  @@
##              master       #3224          +/-   ##
====================================================
- Coverage   67.14175%   35.82973%   -31.31203%     
====================================================
  Files           1381         917         -464     
  Lines         503210      250454      -252756     
  Branches       40768       36667        -4101     
====================================================
- Hits          337864       89737      -248127     
+ Misses        159622      155675        -3947     
+ Partials        5724        5042         -682
Flag Coverage Δ
#Debug 35.82973% <60.94571%> (-31.31203%) ⬇️
#production 35.82973% <60.94571%> (+0.13926%) ⬆️
#test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@RussKie RussKie merged commit d93a2d4 into dotnet:master Aug 12, 2020
@RussKie RussKie deleted the Issue_3223_ListView_UIA_Accessibility branch August 12, 2020 11:12
@ghost ghost added this to the 5.0 RC1 milestone Aug 12, 2020
@RussKie RussKie mentioned this pull request Sep 22, 2020
Closed
@vladimir-krestov vladimir-krestov mentioned this pull request Sep 30, 2020
Merged
vladimir-krestov pushed a commit to vladimir-krestov/winforms that referenced this pull request Oct 2, 2020
@SergeySmirnov-Akvelon @vladimir-krestov
Add Toggle pattern support for ListView items
b88d926 
Related to PR dotnet#3963 and PR dotnet#3224
Fix keyboard Narrator announcing the check/uncheck state of ListView item when enabling ListView CheckBoxes property
Fixes Issue dotnet#4029
@vladimir-krestov vladimir-krestov mentioned this pull request Oct 12, 2020
Merged
@vladimir-krestov vladimir-krestov mentioned this pull request Dec 4, 2020
Closed
@StevenBonePgh StevenBonePgh mentioned this pull request Mar 30, 2021
Closed
This was referenced Apr 12, 2021
Closed
Closed
Merged
Merged
ghost pushed a commit that referenced this pull request Apr 21, 2021
@SergeySmirnov-Akvelon
Fix rectangle of the ListViewGroup (#4800)
76e7021 
Fixes #4778


## Proposed changes
- The issue with the incorrect rectangle is reproduced because the "FragmentRoot" property was not overridden. Added an override for the "FragmentRoot" property.
- Fixed issue with getting a rectangle for a ListViewGroup. Now, instead of the ListViewGroup index, we use the group ID. Fixed a issue with getting an incorrect ListViewGroup index.
- Added unit tests. Fixed typos in unit-tests naming


<!-- We are in TELL-MODE the following section must be completed -->

## Customer Impact
### Case 1
**Before fix:**
![Issue-4778-case1-before](https://user-images.githubusercontent.com/23376742/114997193-41c42500-9ea8-11eb-9d8d-dd2fed7be588.png)

**After fix:**
![Issue-4778-case1-after](https://user-images.githubusercontent.com/23376742/114997486-8e0f6500-9ea8-11eb-8e14-0aae753335ac.png)

### Case 2
**Before fix:**
![Issue-4778-case2-before](https://user-images.githubusercontent.com/23376742/114997915-0bd37080-9ea9-11eb-8203-d76619915de9.png)

**After fix:**
![Issue-4778-case2-after](https://user-images.githubusercontent.com/23376742/114997927-1130bb00-9ea9-11eb-80fe-bee59783f3cf.png)

## Regression? 

- Yes (from #3224)

## Risk

- Minimal

## Test methodology <!-- How did you ensure quality? -->
- CTI team
- unit tests

## Accessibility testing  <!-- Remove this section if PR does not change UI -->
- Inspector

## Test environment(s) <!-- Remove any that don't apply -->
- Microsoft Windows [Version 10.0.19041.388]
- .NET Core SDK: 6.0.100-preview.2.21155.3
wreuel added a commit to wreuel/winforms that referenced this pull request Apr 28, 2021
@wreuel
Squashed commit of the following:
6ab473b 
commit ca0630b
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Apr 28 23:21:46 2021 +1000

    [main] Update dependencies from dotnet/runtime (dotnet#4852)

    * Update dependencies from https://github.com/dotnet/runtime build 20210427.1

    Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.NETCore.Targets , Microsoft.Win32.Registry , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.FileSystem.AccessControl , System.IO.Packaging , System.IO.Pipes.AccessControl , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.AccessControl , runtime.win-x64.Microsoft.NETCore.ILAsm , System.Configuration.ConfigurationManager , System.CodeDom , runtime.win-x86.Microsoft.NETCore.ILAsm , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Pkcs , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Principal.Windows , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
     From Version 6.0.0-preview.5.21226.1 -> To Version 6.0.0-preview.5.21227.1

    * Update dependencies from https://github.com/dotnet/runtime build 20210427.7

    Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.NETCore.Targets , Microsoft.Win32.Registry , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.FileSystem.AccessControl , System.IO.Packaging , System.IO.Pipes.AccessControl , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.AccessControl , System.Configuration.ConfigurationManager , runtime.win-x64.Microsoft.NETCore.ILAsm , System.CodeDom , runtime.win-x86.Microsoft.NETCore.ILAsm , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Pkcs , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Principal.Windows , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
     From Version 6.0.0-preview.5.21226.1 -> To Version 6.0.0-preview.5.21227.7

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 9321ce6
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue Apr 27 20:30:13 2021 +1000

    [main] Update dependencies from dotnet/runtime (dotnet#4848)

commit 10b48cc
Author: Stephen Toub <stoub@microsoft.com>
Date:   Mon Apr 26 03:53:10 2021 -0400

    Add MetadataUpdateHandler to WinForms to repaint all open forms (dotnet#4831)

commit 02ba694
Author: Igor Velikorossov <RussKie@users.noreply.github.com>
Date:   Mon Apr 26 17:34:52 2021 +1000

    VS config (dotnet#4842)

commit 8063e5c
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sun Apr 25 12:33:24 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210424.4 (dotnet#4845)

    [main] Update dependencies from dotnet/runtime

commit df5c5ae
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sat Apr 24 12:56:20 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210424.1 (dotnet#4844)

    [main] Update dependencies from dotnet/runtime

commit 7020d4b
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sat Apr 24 12:55:11 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210422.1 (dotnet#4843)

    [main] Update dependencies from dotnet/arcade

commit 973db87
Author: Igor Velikorossov <RussKie@users.noreply.github.com>
Date:   Sat Apr 24 15:37:13 2021 +1000

    Editor Guidelines config (dotnet#4836)

    https://marketplace.visualstudio.com/items?itemName=PaulHarrington.EditorGuidelines

commit 5ba42a1
Author: Igor Velikorossov <RussKie@users.noreply.github.com>
Date:   Sat Apr 24 15:36:48 2021 +1000

    Script to mark API as shipped (dotnet#4837)

commit 5d05007
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Fri Apr 23 12:43:12 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210422.13 (dotnet#4840)

    [main] Update dependencies from dotnet/runtime

commit 3e70d7e
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu Apr 22 12:51:23 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210422.1 (dotnet#4827)

    [main] Update dependencies from dotnet/runtime

commit 9613a57
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu Apr 22 12:45:22 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210421.1 (dotnet#4826)

    [main] Update dependencies from dotnet/arcade

commit 90efa2b
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu Apr 22 07:59:08 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210421.1 (dotnet#4823)

    [main] Update dependencies from dotnet/runtime

commit 267a19d
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Apr 21 17:33:13 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210420.2 (dotnet#4822)

    [main] Update dependencies from dotnet/arcade

commit 76e7021
Author: Sergey Smirnov <sergey.smirnov@akvelon.com>
Date:   Wed Apr 21 11:34:04 2021 +0300

    Fix rectangle of the ListViewGroup (dotnet#4800)

    Fixes dotnet#4778

    ## Proposed changes
    - The issue with the incorrect rectangle is reproduced because the "FragmentRoot" property was not overridden. Added an override for the "FragmentRoot" property.
    - Fixed issue with getting a rectangle for a ListViewGroup. Now, instead of the ListViewGroup index, we use the group ID. Fixed a issue with getting an incorrect ListViewGroup index.
    - Added unit tests. Fixed typos in unit-tests naming

    <!-- We are in TELL-MODE the following section must be completed -->

    ## Customer Impact
    ### Case 1
    **Before fix:**
    ![Issue-4778-case1-before](https://user-images.githubusercontent.com/23376742/114997193-41c42500-9ea8-11eb-9d8d-dd2fed7be588.png)

    **After fix:**
    ![Issue-4778-case1-after](https://user-images.githubusercontent.com/23376742/114997486-8e0f6500-9ea8-11eb-8e14-0aae753335ac.png)

    ### Case 2
    **Before fix:**
    ![Issue-4778-case2-before](https://user-images.githubusercontent.com/23376742/114997915-0bd37080-9ea9-11eb-8203-d76619915de9.png)

    **After fix:**
    ![Issue-4778-case2-after](https://user-images.githubusercontent.com/23376742/114997927-1130bb00-9ea9-11eb-80fe-bee59783f3cf.png)

    ## Regression?

    - Yes (from dotnet#3224)

    ## Risk

    - Minimal

    ## Test methodology <!-- How did you ensure quality? -->
    - CTI team
    - unit tests

    ## Accessibility testing  <!-- Remove this section if PR does not change UI -->
    - Inspector

    ## Test environment(s) <!-- Remove any that don't apply -->
    - Microsoft Windows [Version 10.0.19041.388]
    - .NET Core SDK: 6.0.100-preview.2.21155.3

commit 7ecc0cf
Author: Jeremy Kuhne <jkuhne@microsoft.com>
Date:   Tue Apr 20 19:26:13 2021 -0700

    Don't use Marshal.SizeOf for SCROLLINFO (dotnet#4819)

commit 29cd684
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Apr 21 12:25:18 2021 +1000

    [main] Update dependencies from dotnet/arcade (dotnet#4817)

commit ebe1bee
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue Apr 20 12:51:05 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210419.10 (dotnet#4818)

    [main] Update dependencies from dotnet/runtime

commit 248b732
Merge: 374b00e 03bd984
Author: Jeremy Kuhne <jkuhne@microsoft.com>
Date:   Mon Apr 19 17:03:10 2021 -0700

    Merge pull request dotnet#4814 from JeremyKuhne/newgetcontext

    Use new GetContext overloads

commit 03bd984
Author: Jeremy Kuhne <jkuhne@microsoft.com>
Date:   Mon Apr 19 16:00:36 2021 -0700

    Use new GetContext overloads

    Use new Graphics.GetContext overloads that minimize allocations and remove warning suppression.

commit 374b00e
Merge: 3e372a1 66df1fa
Author: Jeremy Kuhne <jkuhne@microsoft.com>
Date:   Mon Apr 19 14:58:51 2021 -0700

    Merge pull request dotnet#4802 from dotnet/darc-main-81e048c2-036b-4ff2-9f48-45ff7c71cc72

    [main] Update dependencies from dotnet/runtime

commit 3e372a1
Merge: 7098999 a0ccc42
Author: Jeremy Kuhne <jkuhne@microsoft.com>
Date:   Mon Apr 19 13:41:58 2021 -0700

    Merge pull request dotnet#4811 from JeremyKuhne/syslib16

    Disable SYSLIB0016 warning

commit a0ccc42
Author: Jeremy Kuhne <jkuhne@microsoft.com>
Date:   Mon Apr 19 12:57:21 2021 -0700

    Disable SYSLIB0016 warning

    This is a new obsoletion in System.Drawing. Disabling so we can consume the new build. Will follow this change with another that consumes the newer API.

commit 66df1fa
Author: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sun Apr 18 12:07:45 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210418.1

    Microsoft.NETCore.Platforms , Microsoft.NETCore.Targets , Microsoft.Win32.Registry , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.ILAsm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.FileSystem.AccessControl , System.IO.Packaging , System.IO.Pipes.AccessControl , System.Diagnostics.EventLog , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.AccessControl , System.Security.Cryptography.Cng , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Pkcs , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Principal.Windows , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
     From Version 6.0.0-preview.4.21214.9 -> To Version 6.0.0-preview.5.21218.1

commit 7098999
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sat Apr 17 12:39:44 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210416.2 (dotnet#4806)

    [main] Update dependencies from dotnet/arcade

commit b76c1b3
Author: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sat Apr 17 12:10:32 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210417.1

    Microsoft.NETCore.Platforms , Microsoft.NETCore.Targets , Microsoft.Win32.Registry , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.ILAsm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.FileSystem.AccessControl , System.IO.Packaging , System.IO.Pipes.AccessControl , System.Diagnostics.EventLog , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.AccessControl , System.Security.Cryptography.Cng , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Pkcs , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Principal.Windows , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
     From Version 6.0.0-preview.4.21214.9 -> To Version 6.0.0-preview.5.21217.1

commit b53c2eb
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Fri Apr 16 12:40:23 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210415.5 (dotnet#4801)

    [main] Update dependencies from dotnet/arcade

commit b1f43ab
Author: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Date:   Fri Apr 16 12:10:49 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210415.13

    Microsoft.Win32.Registry , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.NETCore.Targets , Microsoft.NETCore.Platforms , Microsoft.NETCore.ILAsm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILDAsm , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.FileSystem.AccessControl , System.IO.Packaging , System.IO.Pipes.AccessControl , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.AccessControl , System.Configuration.ConfigurationManager , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Security.Cryptography.Cng , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.Security.Principal.Windows , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Windows.Extensions
     From Version 6.0.0-preview.4.21214.9 -> To Version 6.0.0-preview.4.21215.13

commit c9287e9
Author: Devendar Reddy Adulla <dreddy@microsoft.com>
Date:   Thu Apr 15 19:12:24 2021 -0700

    Branding change for Winforms 6.0 preview 5 (dotnet#4799)

commit ecfb941
Author: Devendar Reddy Adulla <dreddy@microsoft.com>
Date:   Thu Apr 15 18:12:20 2021 -0700

    SHipped APIs for Preview4 (dotnet#4798)

commit f379253
Author: Sergey Smirnov <sergey.smirnov@akvelon.com>
Date:   Fri Apr 16 03:20:04 2021 +0300

    Fix Empty ListViewGroups are displayed in the Inspect tree dotnet#4779 (dotnet#4789)

    In this issue, we have two problems with invisible ListViewGroups and invisible ListViewItems.

    An ListViewItem is considered invisible when it is in a ListViewGroup but not added to the ListView. In this case, the ListViewGroup contains data about it, but the ListViewItem is not displayed in the list. To solve this problem, the "GetVisibleItems" method was added, which returns a list of only displayed ListViewItems, in which the property "ListView" is not empty. Now, when receiving data about the ListViewItems of a ListViewGroup, we use this method and not "Items" property of the ListViewGroup.

    The second issue, if the ListViewGroup is empty or contains invisible ListViewItems (case above), then this ListViewGroup is also not displayed in the ListView. This issue was solved in the same way as the issue above, by adding the "GetVisibleGroups" method that returns a list of only the displayed ListViewGroups.

    Added unit tests for ListViewAccessibleObject, ListViewGroupAccessibleObject, ListViewItemAccessibleObject

commit 970b01a
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu Apr 15 12:51:35 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210414.9 (dotnet#4795)

    [main] Update dependencies from dotnet/runtime

commit 2c9de98
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu Apr 15 12:45:45 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210414.5 (dotnet#4794)

    [main] Update dependencies from dotnet/arcade

commit f188aa6
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Apr 14 12:49:07 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210413.3 (dotnet#4792)

    [main] Update dependencies from dotnet/runtime

commit 7e785d0
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Apr 14 00:12:18 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210412.6 (dotnet#4783)

    [main] Update dependencies from dotnet/arcade

commit 7916a2c
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue Apr 13 12:46:42 2021 +0000

    Update dependencies from https://github.com/dotnet/runtime build 20210413.1 (dotnet#4784)

    [main] Update dependencies from dotnet/runtime
@ghost ghost locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sgrebnov sgrebnov sgrebnov left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik left review comments

@Ryuugamine Ryuugamine Ryuugamine left review comments

@vladimir-krestov vladimir-krestov vladimir-krestov requested changes

@weltkante weltkante weltkante requested changes

@RussKie RussKie RussKie approved these changes

Assignees

@M-Lipin M-Lipin

@Ryuugamine Ryuugamine

Labels
None yet
Projects
None yet
Milestone
5.0 RC1
7 participants
@M-Lipin @RussKie @weltkante @Ryuugamine @sgrebnov @Tanya-Solyanik @vladimir-krestov