Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the incorrect ControlType value of ListView subitem #4090

Conversation

vladimir-krestov
Copy link
Contributor

@vladimir-krestov vladimir-krestov commented Oct 12, 2020

Fixes #4032

Proposed changes

  • Change the first subitem ControlType depending ListView.LabelEdit value.
    The first subitem has "text" ControlType if LabelEdit is false
    and it has "edit" ControlType if LabelEdit is true.
    The rest subitems always are "text".
    The implementation is consistent with .Net Framework 4.7.2 behavior.

Customer Impact

  • A user can see a correct ControlType value of the first subitem in a ListView if ListView.LabelEdit is true

Regression?

Risk

  • Minimal

Screenshots

Before

  • The first subitem always has "text" ControlType (ListView.LabelEdit is true or false)
    image

After

  • The first subitem has the correct ControlType value:
    1.ListView.LabelEdit is true - "edit"
    image

    2.ListView.LabelEdit is false - "text"
    image

Test methodology

  • CTI
  • Unit tests
  • Manual testing

Accessibility testing

  • Using Inspect

Test environment(s)

  • .Net 6.0.100-alpha.1.20479.7
  • Microsoft Windows [Version 10.0.19042.508]
Microsoft Reviewers: Open in CodeFlow

The first subitem has "text" ControlType if LabelEdit is false
and it has "edit" ControlType if LabelEdit is true.
The rest subitems always are "text".

Fixes dotnet#4032
@vladimir-krestov vladimir-krestov requested a review from a team as a code owner October 12, 2020 10:58
@vladimir-krestov vladimir-krestov added the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@eef29ed). Click here to learn what that means.
The diff coverage is 100.00000%.

@@             Coverage Diff              @@
##             master       #4090   +/-   ##
============================================
  Coverage          ?   68.11716%           
============================================
  Files             ?        1478           
  Lines             ?      508794           
  Branches          ?       41439           
============================================
  Hits              ?      346576           
  Misses            ?      155985           
  Partials          ?        6233           
Flag Coverage Δ
#Debug 68.11716% <100.00000%> (?)
#production 37.14510% <100.00000%> (?)
#test 98.13715% <100.00000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@vladimir-krestov
Copy link
Contributor Author

Testers approved the fix ✔️
cc:/ @RussKie

@vladimir-krestov vladimir-krestov added waiting-review This item is waiting on review by one or more members of team and removed 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) labels Oct 22, 2020
@RussKie RussKie removed the waiting-review This item is waiting on review by one or more members of team label Oct 23, 2020
@RussKie RussKie merged commit 46e61d3 into dotnet:master Oct 23, 2020
@ghost ghost added this to the 6.0 Preview1 milestone Oct 23, 2020
@vladimir-krestov vladimir-krestov deleted the Issue_4032_FixingControlType_OfListViewTextItems branch November 4, 2020 07:37
@ghost ghost locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect ListView subitem ControlType in edit mode
2 participants