Combine PropertyGrid tab information. #6108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine tab related data into a record for clarity and safety. Use a List<> instead of an array to avoid complicated insert logic. Maintain tab selection as an instance instead of an index. Move error handling to CreateTab so thrown exceptions with messages (missing a bitmap / name for the tab) are actually thrown instead of a silent failure.
ghost
assigned 
|
Arm failed with |
Tanya-Solyanik
previously approved these changes
Nov 3, 2021
Didn't see any reference to it, just tagging it for now as this is the "first" occurrence. |
Tanya-Solyanik
approved these changes
Nov 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine tab related data into a record for clarity and safety. Use a List<> instead of an array to avoid complicated insert logic.
Maintain tab selection as an instance instead of an index.
Move error handling to CreateTab so thrown exceptions with messages (missing a bitmap / name for the tab) are actually thrown instead of a silent failure.
Microsoft Reviewers: Open in CodeFlow