-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Padding of leaf nodes for all levels #389
Conversation
Pull Request Test Coverage Report for Build 1432
💛 - Coveralls |
src/tree-node/toggle.js
Outdated
const toggleCx = ['toggle', expanded && 'expanded', !expanded && 'collapsed'].filter(Boolean).join(' ') | ||
|
||
if (isLeaf) { | ||
return (<i role="button" tabIndex={-1} className={toggleCx} style={{ visibility: 'hidden' }} aria-hidden />) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace (<i·role="button"·tabIndex={-1}·className={toggleCx}·style={{·visibility:·'hidden'·}}·aria-hidden·/>)
with <i·role="button"·tabIndex={-1}·className={toggleCx}·style={{·visibility:·'hidden'·}}·aria-hidden·/>
d1dc01f
to
ed3307a
Compare
… codeclimate errors rectified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 25768 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit b431bb9 and detected 0 issues on this pull request. View more on Code Climate. |
@all-contributors please add @akarshjairaj for code |
I've put up a pull request to add @akarshjairaj! 🎉 |
@akarshjairaj for future, you may want to sign your commits: https://docs.github.com/en/github/authenticating-to-github/about-commit-signature-verification |
🎉 This PR is included in version 2.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@akarshjairaj & @mrchief Did you add I see quite a huge dependency change with the upgrade from |
Let's get rid of it. My bad for not catching it. |
In addition to removing it, I think we should add a gitignore entry to be safe in future.
@mobilutz are there any CI checks we can put in place to detect things like this? |
@mrchief Created a new PR. Apologies for the mistake. |
@akarshjairaj thanks. I'll take a look. Also, please stop being sorry. We all make mistakes.😄 |
What does it do?
Fixed padding (indentation) of leaf nodes for all levels