Skip to content

Commit

Permalink
Merge pull request #1199 from dpc-sdp/bugfix/local-test-images
Browse files Browse the repository at this point in the history
[R20-2009] remove 'external' images and add placeholders
  • Loading branch information
dylankelly authored Jun 3, 2024
2 parents 098c9f8 + 6a192b3 commit 4de1afc
Show file tree
Hide file tree
Showing 40 changed files with 219 additions and 234 deletions.
1 change: 0 additions & 1 deletion examples/nuxt-app/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ node_modules
.nuxt
nuxt.d.ts
.output
public
Binary file added examples/nuxt-app/public/placeholders/large.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added examples/nuxt-app/public/placeholders/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added examples/nuxt-app/public/placeholders/medium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added examples/nuxt-app/public/placeholders/small.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions examples/nuxt-app/test/features/landingpage/home.feature
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ Feature: Home page
Scenario: Primary campaign
Then the "primary" campaign title should be "Demo primary campaign"
Then the "primary" campaign summary should be "Test summary for primary campaign"
Then the "primary" campaign image src should be "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-skyline-at-dusk.jpg"
Then the "primary" campaign image src should be "/placeholders/medium.png"
Then the "primary" campaign CTA label should be "Testing CTA text"
Then clicking the "primary" campaign CTA should take me to "/demo-destination"

@mockserver
Scenario: Secondary campaign
Then the "secondary" campaign title should be "Demo secondary campaign"
Then the "secondary" campaign summary should be "Test summary for secondary campaign"
Then the "secondary" campaign image src should be "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg"
Then the "secondary" campaign image src should be "/placeholders/medium.png"
Then the "secondary" campaign CTA label should be "Testing secondary CTA text"
Then clicking the "secondary" campaign CTA should take me to "/demo-secondary-destination"

Expand Down
48 changes: 24 additions & 24 deletions examples/nuxt-app/test/features/landingpage/page-components.feature
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ Feature: Home page
| noImage | Promo card (noImage) | Sample description | |

Then a promo card with ID "977" should exist with the following properties
| displayStyle | title | content | image |
| thumbnail | Promo card (thumbnail) | Sample description | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg |
| displayStyle | title | content | image |
| thumbnail | Promo card (thumbnail) | Sample description | /placeholders/medium.png |

Then a promo card with ID "978" should exist with the following properties
| displayStyle | title | content | image |
| profile | Promo card (profile) | Sample description | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg |
| displayStyle | title | content | image |
| profile | Promo card (profile) | Sample description | /placeholders/medium.png |

@mockserver
Scenario: Page component - Nav card
Expand All @@ -47,12 +47,12 @@ Feature: Home page
| noImage | Nav card (noImage) | Sample description | |

Then a nav card with ID "982" should exist with the following properties
| displayStyle | title | content | image |
| thumbnail | Nav card (thumbnail) | Sample description | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg |
| displayStyle | title | content | image |
| thumbnail | Nav card (thumbnail) | Sample description | /placeholders/medium.png |

Then a nav card with ID "983" should exist with the following properties
| displayStyle | title | content | image |
| featured | Nav card (featured) | Sample description | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg |
| displayStyle | title | content | image |
| featured | Nav card (featured) | Sample description | /placeholders/medium.png |


@mockserver
Expand All @@ -68,16 +68,16 @@ Feature: Home page
Scenario: Page component - Timeline
Then a timeline with ID "992" should exist with the title "Test timeline title"
Then a timeline with ID "992" should exist with the following items
| title | date | summary | url | image |
| Milestone 1 title | 2 June to 11 November | Milestone 1 summary field | /test-destination-1 | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/VicFleet-Police-car-on-road.jpg |
| Milestone 2 title | 4 October to 17 November | Milestone 2 summary field | /test-destination-2 | |
| Milestone 3 title | | Milestone 3 text | | |
| title | date | summary | url | image |
| Milestone 1 title | 2 June to 11 November | Milestone 1 summary field | /test-destination-1 | /placeholders/small.png |
| Milestone 2 title | 4 October to 17 November | Milestone 2 summary field | /test-destination-2 | |
| Milestone 3 title | | Milestone 3 text | | |

@mockserver
Scenario: Page component - Call to action
Then a call to action with ID "1024" should exist with the following properties
| title | summary | ctaText | image |
| Test call to action title | This is the description | Test CTA text | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Two-men-working-in-hi-vis-clothing.jpg |
| title | summary | ctaText | image |
| Test call to action title | This is the description | Test CTA text | /placeholders/medium.png |

@mockserver
Scenario: Page component - Stats grid
Expand All @@ -89,9 +89,9 @@ Feature: Home page
@mockserver
Scenario: Page component - Card carousel
Given a card carousel with ID "1155" should exist with the following promo cards
| title | date | content | url | image |
| Sample title | 1 Dec to 31 Dec | Sample Card Summary | /sample-page | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Aerial-shot-of-new-housing-development.jpg |
| Promotion title | 3 Nov 2022 | Promotion Card summary | /promo-page | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Engage-Vic-photo-hero.jpeg |
| title | date | content | url | image |
| Sample title | 1 Dec to 31 Dec | Sample Card Summary | /sample-page | /placeholders/medium.png |
| Promotion title | 3 Nov 2022 | Promotion Card summary | /promo-page | /placeholders/medium.png |
And the card carousel with ID "1155" should contain a key dates card with the title "Key calendar dates", link "/dates" and the following entries
| title | subtitle | content |
| April 16th | Key subtitle 1 | Key content 1 |
Expand All @@ -109,10 +109,10 @@ Feature: Home page
@mockserver
Scenario: Page component - Media Gallery
Given a media gallery with ID "1056" should exist with the following gallery items
| title | caption | image |
| Media title one | The first media caption | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/2018-19-State-Budget.jpg |
| Media title two | The second media caption | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Aerial-shot-of-new-housing-development.jpg |
| Media title three | The third media caption | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Bendigo-Hospital.jpg |
| title | caption | image |
| Media title one | The first media caption | /placeholders/medium.png |
| Media title two | The second media caption | /placeholders/medium.png |
| Media title three | The third media caption | /placeholders/medium.png |

@mockserver
Scenario: Page component - Media Gallery (Slider)
Expand Down Expand Up @@ -154,6 +154,6 @@ Feature: Home page
@mockserver
Scenario: Page component - Category Grid i.e. compact cards
Then a category grid with ID "7052" should exist with the following cards
| title | content | image | url |
| Card one | Card one summary | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Aerial-shot-of-new-housing-development.jpg | /landing-page-cc-2 |
| Card two | Card two summary | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/2018-19-State-Budget.jpg | https://google.com/ |
| title | content | image | url |
| Card one | Card one summary | /placeholders/medium.png | /landing-page-cc-2 |
| Card two | Card two summary | /placeholders/medium.png | https://google.com/ |
6 changes: 3 additions & 3 deletions examples/nuxt-app/test/features/site/shared-elements.feature
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ Feature: Shared site elements
Then the footer copyright text should be "Test footer copyright html"
Then the footer acknowledgement text should be "Test footer acknowledgement"
Then the footer should have the following logos
| alt | url | src |
| Test logo 1 | /test-logo-1 | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Aerial-shot-of-new-housing-development.jpg?w=1984 |
| Test logo 2 | /test-logo-2 | https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/2018-19-State-Budget.jpg?w=1984 |
| alt | url | src |
| Test logo 1 | /test-logo-1 | /placeholders/logo.png?w=1984 |
| Test logo 2 | /test-logo-2 | /placeholders/logo.png?w=1984 |

@mockserver
Scenario: Footer (Mobile)
Expand Down
4 changes: 2 additions & 2 deletions examples/nuxt-app/test/fixtures/event/sample-event.json
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,13 @@
"tag": "meta",
"attributes": {
"property": "og:image",
"content": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg"
"content": "/placeholders/medium.png"
}
}
],
"keywords": "",
"image": {
"src": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg",
"src": "/placeholders/medium.png",
"alt": "Demo: Melbourne tram",
"title": "Demo: Melbourne tram",
"width": 1413,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"title": "Demo Timeline Item",
"subtitle": null,
"url": "https://www.google.com",
"image": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg",
"image": "/placeholders/medium.png",
"dateStart": "2020-01-01T19:00:00+11:00",
"dateEnd": "2020-01-01T21:00:00+11:00",
"description": "Mauris tincidunt tincidunt felis vel tempus. Vestibulum rhoncus blandit justo quis finibus."
Expand All @@ -55,7 +55,7 @@
"title": "Demo Timeline Item 2",
"subtitle": "Alternative",
"url": "https://www.google.com",
"image": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg",
"image": "/placeholders/medium.png",
"dateStart": null,
"dateEnd": null,
"description": "Anim excepteur magna eu aliqua quis velit voluptate sit culpa."
Expand Down Expand Up @@ -120,13 +120,13 @@
"tag": "meta",
"attributes": {
"property": "og:image",
"content": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg"
"content": "/placeholders/medium.png"
}
}
],
"keywords": "",
"image": {
"src": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg",
"src": "/placeholders/medium.png",
"alt": "Demo: Melbourne tram",
"title": "Demo: Melbourne tram",
"width": 1413,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,13 @@
"tag": "meta",
"attributes": {
"property": "og:image",
"content": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg"
"content": "/placeholders/medium.png"
}
}
],
"keywords": "",
"image": {
"src": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg",
"src": "/placeholders/medium.png",
"alt": "Demo: Melbourne tram",
"title": "Demo: Melbourne tram",
"width": 1413,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,13 @@
"tag": "meta",
"attributes": {
"property": "og:image",
"content": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg"
"content": "/placeholders/medium.png"
}
}
],
"keywords": "",
"image": {
"src": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg",
"src": "/placeholders/medium.png",
"alt": "Demo: Melbourne tram",
"title": "Demo: Melbourne tram",
"width": 1413,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,13 @@
"tag": "meta",
"attributes": {
"property": "og:image",
"content": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg"
"content": "/placeholders/medium.png"
}
}
],
"keywords": "",
"image": {
"src": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg",
"src": "/placeholders/medium.png",
"alt": "Demo: Melbourne tram",
"title": "Demo: Melbourne tram",
"width": 1413,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,13 @@
"tag": "meta",
"attributes": {
"property": "og:image",
"content": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg"
"content": "/placeholders/medium.png"
}
}
],
"keywords": "",
"image": {
"src": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg",
"src": "/placeholders/medium.png",
"alt": "Demo: Melbourne tram",
"title": "Demo: Melbourne tram",
"width": 1413,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,13 @@
"tag": "meta",
"attributes": {
"property": "og:image",
"content": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg"
"content": "/placeholders/medium.png"
}
}
],
"keywords": "",
"image": {
"src": "https://develop.content.reference.sdp.vic.gov.au/sites/default/files/tide_demo_content/Melbourne-tram.jpg",
"src": "/placeholders/medium.png",
"alt": "Demo: Melbourne tram",
"title": "Demo: Melbourne tram",
"width": 1413,
Expand Down
Loading

0 comments on commit 4de1afc

Please sign in to comment.