Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-2009] remove 'external' images and add placeholders #1199

Merged
merged 2 commits into from
Jun 3, 2024
Merged

[R20-2009] remove 'external' images and add placeholders #1199

merged 2 commits into from
Jun 3, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 2, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-2009

What I did

  • Remove 'external' images and add placeholders

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 2, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 2, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 6a192b3
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/665cf619175834000800ad8f

@lambry lambry changed the title ci(nuxt-app): remove 'external' images and add placeholders [R20-2009] remove 'external' images and add placeholders Jun 2, 2024
@cypress Cypress
Copy link

cypress bot commented Jun 2, 2024 •
edited
Loading

Passing run #1833 ↗︎

0 155 0 0 Flakiness 0

Details:

Merge branch 'develop' into bugfix/local-test-images
Project: ripple-framework Commit: 6a192b3c57
Status: Passed Duration: 07:24 💡
Started: Jun 2, 2024 10:48 PM Ended: Jun 2, 2024 10:55 PM

Review all test suite changes for PR #1199 ↗︎

dylankelly
dylankelly approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@dylankelly dylankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lambry is the real MVP!

@dylankelly dylankelly added this pull request to the merge queue Jun 3, 2024
Merged via the queue into develop with commit 4de1afc Jun 3, 2024
8 checks passed
@dylankelly dylankelly deleted the bugfix/local-test-images branch June 3, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly