Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-329] campaign feedback #1213

Merged
merged 3 commits into from
Jun 10, 2024
Merged

[R20-329] campaign feedback #1213

merged 3 commits into from
Jun 10, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 7, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-329

What I did

  • The original implementation used flex box, but things didn't quite fit 'the grid' exactly, and the CSS wasn't super maintainable, so for CSS simplicity and design accuracy this removes all that in favor of our grid classes.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 7, 2024
Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 3f27356
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6662805b58aff0000860019a

Copy link

cypress bot commented Jun 7, 2024

Passing run #1885 ↗︎

0 162 0 0 Flakiness 0

Details:

Merge branch 'develop' into feature/campaign-feedback
Project: ripple-framework Commit: 3f273569d0
Status: Passed Duration: 06:37 💡
Started: Jun 7, 2024 3:39 AM Ended: Jun 7, 2024 3:46 AM

Review all test suite changes for PR #1213 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Jun 10, 2024
Merged via the queue into develop with commit c04717a Jun 10, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the feature/campaign-feedback branch June 10, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants