[R20-1581] feat(@dpc-sdp/nuxt-ripple): adds logging in vue/nuxt contexts #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ripple-docs canceled.
|
Passing run #1117 ↗︎
Details:
Review all test suite changes for PR #962 ↗︎ |
|||||||||||||||
waitingallday
approved these changes
Dec 13, 2023
jeffdowdle
commented
Dec 28, 2023
| @@ -1,6 +1,6 @@ | |||
| # Temporary files | |||
| node_modules | |||
| *.log* | |||
There was a problem hiding this comment.
@dylankelly I had to remove the trailing * from this otherwise it ignores the 00.logging.server.ts file. Not sure if I've broken something by doing this though.
lambry
approved these changes
Dec 28, 2023
dylankelly
reviewed
Jan 8, 2024
| @@ -58,11 +95,22 @@ export const useTidePage = async ( | |||
| if (process.dev) { | |||
| console.log('Cache reset for page', `page-${path}`) | |||
There was a problem hiding this comment.
we can remove this console log now
dylankelly
reviewed
Jan 8, 2024
| nuxtCacheKeys: Object.keys(nuxt.payload.data) | ||
| } | ||
| ) | ||
|
|
||
| if (Object.keys(nuxt.payload.data).length > maxCacheItems + 1) { | ||
| if (process.dev) { |
There was a problem hiding this comment.
Can we convert this console log to use debugLogger?
dylankelly
requested changes
Jan 8, 2024
dylankelly
changed the title
dylankelly
approved these changes
Jan 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
How to test
Checklist
For all PR's
For new components only