-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R20-1581] feat(@dpc-sdp/nuxt-ripple): adds logging in vue/nuxt contexts #962
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
18c1f12
feat(@dpc-sdp/nuxt-ripple): adds logging in vue/nuxt contexts
jeffdowdle 9d858e2
Merge branch 'develop' into feature/nuxt-logging
jeffdowdle 525f831
feat(@dpc-sdp/ripple-tide-api): add section id to logging messages an…
jeffdowdle 518dc09
Merge branch 'develop' into feature/nuxt-logging
jeffdowdle 1b2821d
style(@dpc-sdp/nuxt-ripple): fixed linting
jeffdowdle 3c0ae7f
chore: remove console log
dylankelly 4678b2a
Merge branch 'develop' into feature/nuxt-logging
dylankelly e70e098
Merge branch 'develop' into feature/nuxt-logging
dylankelly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
# Temporary files | ||
node_modules | ||
*.log* | ||
*.log | ||
.nuxt | ||
.nitro | ||
.cache | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
export const useLogger = () => { | ||
const { $logger } = useNuxtApp() | ||
const noop = () => {} | ||
|
||
if (process.server) { | ||
return $logger | ||
} | ||
|
||
return { | ||
debug: noop, | ||
info: noop, | ||
warning: noop, | ||
error: noop | ||
} | ||
} | ||
|
||
export default useLogger |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { useRequestHeaders } from '#imports' | ||
|
||
export const useSectionId = (): string => { | ||
const sectionIdHeaderName = 'section-io-id' | ||
const requestHeaders = useRequestHeaders([sectionIdHeaderName]) | ||
return requestHeaders[sectionIdHeaderName] || 'no section id' | ||
} | ||
|
||
export default useSectionId |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { defineNuxtPlugin } from '#app' | ||
import { logger } from '@dpc-sdp/ripple-tide-api' | ||
|
||
export default defineNuxtPlugin(() => { | ||
return { | ||
provide: { | ||
logger | ||
} | ||
} | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dylankelly I had to remove the trailing * from this otherwise it ignores the
00.logging.server.ts
file. Not sure if I've broken something by doing this though.