Skip to content

Commit

Permalink
Merge pull request openshift#2240 from ggreer/safety-first
Browse files Browse the repository at this point in the history
Don't call super.componentWillUnmount from componentWillMount.
  • Loading branch information
ggreer authored Apr 18, 2018
2 parents 26d1bf7 + 4301b0b commit d9e3f48
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion frontend/public/components/graphs/donut.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export class Donut extends SafetyFirst {
}

componentWillMount () {
super.componentWillUnmount();
clearInterval(this.interval);
this.fetch();
window.addEventListener('resize', this.resize);
}
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/components/graphs/status.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class Status extends SafetyFirst {
}

componentWillMount () {
super.componentWillUnmount();
clearInterval(this.interval);
this.fetch();
}

Expand Down

0 comments on commit d9e3f48

Please sign in to comment.