Support Chunk Prefetch By Generating a New Blob And Bootstrap #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daiyongxuan
requested review from
jiangliu,
gaius-qi and
Desiki-high
and removed request for
a team
kevinXYin
reviewed
Oct 10, 2024
| let child = tree.get_node(&node.lock().unwrap().path()).unwrap(); | ||
| let mut child = child.node.lock().unwrap(); | ||
| child.layer_idx = prefetch_blob_index as u16; | ||
| for chunk in &mut child.chunks { |
There was a problem hiding this comment.
Hi , nice job!
how about just construct the new blob based on the compressed chunks from the original blob here, without needing to revert_files or modify the Blob::dump
# This is the 1st commit message: Feat: Add Prefetch Bootstrap Build # This is the commit message dragonflyoss#2: sync tag: Add a runable example add prefetch bootstrap Refactor: change the test root WIP: gen an empty blob, enter in blob.rs:33 chore: remove unused comments WIP: generate blob id WIP: update blob id Refractor: remove some unuseful import and parameters WIP: need to encapsulation the reader ROLLBACK: Generate a blob WIP: Revert files WIP: revert files WIP: Generate Blob And Compute Blob ID feat: Generate Prefetch blobs refractor: remove some unuse imports and functions Add #![deny(warnings)] to enforce warning-free code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue #1589
The objective is to create an independent image layer to prioritize the fetching of necessary blobs during startup, enhancing performance.
Details
This introduces the "optimize" subcommand, which generates a new blob containing prefetch files and creates a new RAFS format bootstrap. This ensures compatibility with the nydus-image check and optimizes the startup process.