Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Missing commit_message_template for github workflow #18

Closed
luchsh opened this issue Mar 26, 2019 · 0 comments
Closed

[Bug] Missing commit_message_template for github workflow #18

luchsh opened this issue Mar 26, 2019 · 0 comments
Assignees
@luchsh

Comments

@luchsh
Copy link
Contributor

luchsh commented Mar 26, 2019

Description
Alibaba Dragonwell used to pick up patches directly from Alibaba's internal build whose test/review process is not visible to external users. To better fit into the shoes of github.com while keeping a good shape of code quality, we need a template for git commit messages.

Steps to Reproduce
Steps to reproduce the behavior:

  • Clone Alibaba Dragonwell8 repository git@github.com:alibaba/dragonwell8.git
  • Found no template for git commit -a -t <template>

Expected behavior
git commit -a -t .github/commit_message_template
should give developers a guide on how to write a commit message for Alibaba Dragonwell.

JDK version
Affects preview versions only:
openjdk version "1.8.0_202"
OpenJDK Runtime Environment (Dragonwell 8.0-preview) (build 1.8.0_202-b30)
OpenJDK 64-Bit Server VM (Dragonwell 8.0-preview) (build 25.202-b30, mixed mode)

Execution environment

  • OS and version: Linux, kernel 3.10
  • CPU model: Skylake
  • Number of CPU cores: 64
  • Size of physical memory: 64GB
  • Inside Linux container? No
    • Linux container name (docker, pouch, etc):
    • Linux container version:
@luchsh luchsh self-assigned this Mar 26, 2019
@luchsh luchsh mentioned this issue Mar 26, 2019
Merged
luchsh pushed a commit that referenced this issue Mar 26, 2019
@luchsh
[Misc] Add .github/commit_message_template
9ee08a2 
Summary:
- Added .github/commit_message_template file
- Developers are expected to use following command to create any new Git commits
`git commit -t .github/commit_message_template`

Test Plan: only review needed

Reviewed-by: kuaiwei, sanhong

Issue: #18
@luchsh luchsh closed this as completed Mar 26, 2019
@terwer terwer mentioned this issue Apr 17, 2019
Merged
yfxhust pushed a commit that referenced this issue Jun 22, 2019
@yfxhust
[Misc] Add .github/commit_message_template
3108033 
Summary:
- Added .github/commit_message_template file
- Developers are expected to use following command to create any new Git commits
`git commit -t .github/commit_message_template`

Test Plan: only review needed

Reviewed-by: kuaiwei, sanhong

Issue: #18
@henrysternc henrysternc mentioned this issue Dec 31, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luchsh luchsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luchsh