Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Add .github/commit_message_template #19

Merged
merged 1 commit into from
Mar 26, 2019
Merged

[Misc] Add .github/commit_message_template #19

merged 1 commit into from
Mar 26, 2019

Conversation

luchsh
Copy link
Contributor

@luchsh luchsh commented Mar 26, 2019 •
edited
Loading

Summary:

  • Added .github/commit_message_template file
  • Developers are expected to use following command to create any new Git commits
    git commit -t .github/commit_message_template

Test Plan: only review needed

Reviewed-by: kuaiwei, sanhong

Issue: #18

@luchsh luchsh requested review from kuaiwei and sanhong March 26, 2019 04:16
@CLAassistant
Copy link

CLAassistant commented Mar 26, 2019 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@luchsh luchsh self-assigned this Mar 26, 2019
sanhong
sanhong reviewed Mar 26, 2019
View reviewed changes
Copy link
Collaborator

@sanhong sanhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typo errors

.github/commit_message_template Outdated Show resolved Hide resolved
.github/commit_message_template Outdated Show resolved Hide resolved
[Misc] Add .github/commit_message_template
0bf3b77 
Summary:
- Added .github/commit_message_template file
- Developers are expected to use following command to create any new Git commits
`git commit -t .github/commit_message_template`

Test Plan: only review needed

Reviewed-by: kuaiwei, sanhong

Issue: #18
kuaiwei
kuaiwei approved these changes Mar 26, 2019
View reviewed changes
Copy link
Collaborator

@kuaiwei kuaiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may think pull request in sub modules.

@luchsh luchsh merged commit 9ee08a2 into dragonwell-project:master Mar 26, 2019
@luchsh luchsh deleted the commit_msg_template branch March 26, 2019 06:08
@henrysternc henrysternc mentioned this pull request Dec 31, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanhong sanhong sanhong approved these changes

@kuaiwei kuaiwei kuaiwei approved these changes

Assignees

@luchsh luchsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luchsh @CLAassistant @kuaiwei @sanhong