Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update return types from T to DropboxResponse<T> & Spec Update #352

Merged
merged 4 commits into from
Oct 21, 2020

Conversation

rogebrd
Copy link
Contributor

@rogebrd rogebrd commented Oct 14, 2020

  • Fix bug introduced in v6.0.0 with the addition of the DropboxResponse class
  • Fixes issue (#333) and (#340)
  • Reflecting stone changes introduced in (#192)

Change Notes:

File Namespace:

Add SearchOrderBy unioin
Add SearchMatchTypeV2 union
Update SearchOptions to include order_by
Update SearchMatchV2 to include match_type
Team Audit Log Namespace:

Add TeamBrandingPolicy union
Add TeamBrandingPolicyChangedDetails struct
Add TeamBrandingPolicyChangedType struct
Update EventDetails to include team_branding_policy_changed_details
Update EventType to include team_branding_policy_changed
Update EventTypeArg to include team_branding_policy_changed
Team Reports Namespace:

Deprecate reports/get_storage
Deprecate reports/get_activity
Deprecate reports/get_membership
Deprecate reports/get_devices

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   51.44%   51.44%           
=======================================
  Files           6        6           
  Lines         725      725           
=======================================
  Hits          373      373           
  Misses        352      352           
Flag Coverage Δ
#integration 47.17% <ø> (ø)
#unit 46.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/routes.js 50.93% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63801a4...9ebaeaa. Read the comment docs.

@rogebrd rogebrd requested a review from aelawson October 14, 2020 02:48
Copy link
Contributor

@aelawson aelawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need to make changes to the generator call to make this work, right?

- Fix bug introduced in v6.0.0 with the addition of the DropboxResponse class
- Fixes issue ([#333](#333)) and ([#340](#340))
- Reflecting stone changes introduced in ([#192](dropbox/stone#192))
@rogebrd rogebrd changed the title Update return types from T to DropboxResponse<T> Update return types from T to DropboxResponse<T> & Spec Update Oct 21, 2020
@rogebrd rogebrd merged commit e2677c5 into master Oct 21, 2020
@rogebrd rogebrd deleted the fix_return_types branch October 21, 2020 18:13
@pubmikeb
Copy link

The #333 is not fixed for me after upgrading to 7.2.0, details: #333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getAccessTokenFromCode return type JSDoc types of the GetTemporaryLinkResult interface are not updated
3 participants