Add optional flag allowing wrapping responses in a parent class for J… #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S and TS client - Adds the `--wrap-response-in` flag which allows users to pass in a value - Response will be wrapped in the following way: `wrapper<type>` where `wrapper` is the string passed in with the flag, and `type` is the original response type
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 51.11% 51.17% +0.06%
==========================================
Files 37 37
Lines 8340 8351 +11
Branches 1779 1781 +2
==========================================
+ Hits 4263 4274 +11
Misses 3757 3757
Partials 320 320
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aelawson
approved these changes
Oct 20, 2020
stone/backends/js_client.py
Outdated
| @@ -81,11 +87,21 @@ def _generate_route(self, route_schema, namespace, route): | |||
| if route.deprecated: | |||
| self.emit(' * @deprecated') | |||
|
|
|||
| return_type = None | |||
| if self.args.wrap_response_in: | |||
| if route.result_data_type.__class__ != Void: | |||
There was a problem hiding this comment.
Isn't there value in still doing this for Void type? e.g. if you are providing access to headers with a Response wrapper class like we do in the SDK?
stone/backends/tsd_client.py
Outdated
| fmt_type(route.result_data_type))) | ||
| return_type = None | ||
| if self.args.wrap_response_in: | ||
| if route.result_data_type.__class__ != Void: |
rogebrd
added a commit
to dropbox/dropbox-sdk-js
that referenced
this pull request
Oct 21, 2020
* Update return types from T to DropboxResponse<T> - Fix bug introduced in v6.0.0 with the addition of the DropboxResponse class - Fixes issue ([#333](#333)) and ([#340](#340)) - Reflecting stone changes introduced in ([#192](dropbox/stone#192)) * Regenerate routes with new stone version Change Notes: File Namespace: - Add SearchOrderBy unioin - Add SearchMatchTypeV2 union - Update SearchOptions to include order_by - Update SearchMatchV2 to include match_type Team Audit Log Namespace: - Add TeamBrandingPolicy union - Add TeamBrandingPolicyChangedDetails struct - Add TeamBrandingPolicyChangedType struct - Update EventDetails to include team_branding_policy_changed_details - Update EventType to include team_branding_policy_changed - Update EventTypeArg to include team_branding_policy_changed Team Reports Namespace: - Deprecate reports/get_storage - Deprecate reports/get_activity - Deprecate reports/get_membership - Deprecate reports/get_devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…S and TS client
--wrap-response-inflag which allows users to pass in a valuewrapper<type>wherewrapperis the string passed in with the flag, andtypeis the original response typeChecklist
General Contributing
Is This a Code Change?
Validation
tox?