-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added public function Assert-ElevatedUser #84
Conversation
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
==================================
Coverage 90% 90%
==================================
Files 27 28 +1
Lines 537 544 +7
==================================
+ Hits 488 495 +7
Misses 49 49
|
@johlju - My PR associated with SqlServerDsc #1979, that moves the Please disregard PR #83 |
@hollanjs no worries that you opened a new PR 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hollanjs)
a discussion (no related file):
In the README.md we add the documentation for the command, like syntax. Please add the new command in the correct place (alphabetical order). Unfortunatly we have not yet fixed ths to update automatically, so I usually use the comment-based help and use Get-Help
to get the syntax.
Assert-IPAddress ### Syntax --> #### Syntax
@johlju - I added the cmdlet to the README.md; tried to be as detailed as possible but also succinct since the function really only does 1 thing and doesn't take inputs. I also corrected the 'Syntax' block for |
Great! I wil review this as soon as I can., at the latest on saturday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @hollanjs)
Great work @hollanjs! I will do a full release of this module, then we can review and merge the PR in SqlServerDsc. |
- Add public function `Assert-ElevatedUser` that asserts the user has elevated the PowerShell session. issue #82
Pull Request (PR) description
Moved
Assert-ElevatedUser
from a private function in SqlServerDsc to a public function in DscResource.CommonOriginal issue logged in SqlServerDsc by @johlju Issue #1797
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
DSC Community Testing Guidelines.
This change is