Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert-ElevatedUser: Move to DscResource.Common as a public command #1797

Closed
johlju opened this issue Nov 24, 2022 · 4 comments · Fixed by #1815
Closed

Assert-ElevatedUser: Move to DscResource.Common as a public command #1797

johlju opened this issue Nov 24, 2022 · 4 comments · Fixed by #1815
Assignees
@hollanjs
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Nov 24, 2022

We should look at moving this to DscResource.Common (as a public command).
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Nov 24, 2022
@hollanjs
Copy link
Contributor

hollanjs commented Dec 4, 2022

Could you assign this issue to me? Looking for a "good first issue" and this looks about my speed.

@hollanjs hollanjs mentioned this issue Dec 4, 2022
Closed
@johlju
Copy link
Member Author

johlju commented Dec 4, 2022

This issues suggest that the command should be moved to another repository, DscResource.Common. When you send in a PR in that other repo, tag me in the repo. At the same time send in a PR to this repo removing the command referencing the other PR.

Since this issue is a two parter I will assign you to this when I see the PR in the other repo. Cool?

@hollanjs
Copy link
Contributor

hollanjs commented Dec 4, 2022

Sounds good - thank you for the quick update.

@johlju
Copy link
Member Author

johlju commented Dec 4, 2022

Looking forward to review the PRs. Thank you! 😊

hollanjs added a commit to hollanjs/SqlServerDsc that referenced this issue Dec 4, 2022
@hollanjs
Removed Assert-ElevatedUser ([dsccommunity#1797](dsccommunity#1797))
57e00fe
hollanjs added a commit to hollanjs/SqlServerDsc that referenced this issue Dec 4, 2022
@hollanjs
Removed Assert-ElevatedUser ([dsccommunity#1797](dsccommunity#1797))
752053c
This was referenced Dec 4, 2022
Merged
Merged
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Dec 5, 2022
johlju pushed a commit that referenced this issue Dec 11, 2022
@hollanjs
Assert-ElevatedUser: Function moved to DscResource.Common Module (#1815)
d5692e2 
- SqlServerDsc
  - Removed `Assert-ElevatedUser` from private functions - issue #1797
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollanjs hollanjs

Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assert-ElevatedUser: Function moved to DscResource.Common Module hollanjs/SqlServerDsc
2 participants
@johlju @hollanjs