Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert-ElevatedUser: Function moved to DscResource.Common Module #1815

Merged
merged 4 commits into from
Dec 11, 2022

Conversation

hollanjs
Copy link
Contributor

@hollanjs hollanjs commented Dec 4, 2022

Pull Request (PR) description

Moved Assert-ElevatedUser from a private function in SqlServerDsc to a public function in DscResource.Common
Related Issue adding function to DscResource.Common: Issue #82

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • [ x Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@hollanjs
Copy link
Contributor Author

hollanjs commented Dec 4, 2022

@johlju - My PR for issue #1797. Let me know if it requires any additional updates or changes.

@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Merging #1815 (de89f0b) into main (6c0e426) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1815   +/-   ##
====================================
  Coverage    88%     88%           
====================================
  Files        83      82    -1     
  Lines      7444    7437    -7     
====================================
- Hits       6594    6588    -6     
+ Misses      850     849    -1     
Flag Coverage Δ
unit 88% <ø> (+<1%) ⬆️

@johlju johlju added the needs review The pull request needs a code review. label Dec 5, 2022
@johlju
Copy link
Member

johlju commented Dec 10, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@johlju
Copy link
Member

johlju commented Dec 10, 2022

I'm trying to figure out why the build fails. It has nothing to do with this PR. Probably an issue on the build worker as Azure Pipelines shifted linux version.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @hollanjs)

@johlju johlju merged commit d5692e2 into dsccommunity:main Dec 11, 2022
@johlju johlju removed the needs review The pull request needs a code review. label Dec 11, 2022
@johlju
Copy link
Member

johlju commented Dec 11, 2022

@hollanjs great work on this. Much appreciated to gotten this command moved! 🙇

@hollanjs hollanjs deleted the fix-issue-1797 branch December 16, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert-ElevatedUser: Move to DscResource.Common as a public command
2 participants