fix: Explanation hstack undefined name error #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 52.22% 52.25% +0.03%
==========================================
Files 90 90
Lines 13146 13146
==========================================
+ Hits 6866 6870 +4
+ Misses 6280 6276 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
`hstack` as was initially implemented cannot run because `axis` is not defined. My best guess for the implementation for `hstack` is to hstack the values and return a new Explanation object, rather than doing a "min". I assume that was just a typo / copy-paste error.
thatlittleboy
force-pushed
the
ruff-F821-explanation
branch
from
4ada02a
to
8179889
Compare
connortann
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #54.
Explanation.hstackmethod was using a non-existent variable "axis" (probably copied from the other helper methods likesum). The implementation as it is didn't make any sense, so I modified it to what I think made the most sense, which is to hstack the inner arrays and return a new Explanation object.