fix: ruff rule F841 (unused variable) #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 53.65% 53.63% -0.02%
==========================================
Files 90 90
Lines 12981 12957 -24
==========================================
- Hits 6965 6950 -15
+ Misses 6016 6007 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thatlittleboy
force-pushed
the
ruff-F841-rule
branch
from
5631029
to
6667213
Compare
thatlittleboy
force-pushed
the
ruff-F841-rule
branch
from
250c743
to
64a283d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #21, and is a continuation of PR #25 when ruff was initially introduced to the project.
This PR aims to make the codebase F841-compliant ("Local variables assigned but unused").
For the variables with no clear purpose, I removed them. Some I chose to keep/comment away (somewhat arbitrary decision based on a feeling that it might be useful for future reference, feel free to tell me to delete them).
Dependencies: The
hstackbug of Explanation makes an appearance here too. So PR #86 should be merged in first. ✅ DONE