fix: lightgbm call with categoricals bug #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 53.39% 53.43% +0.04%
==========================================
Files 90 90
Lines 13028 13029 +1
==========================================
+ Hits 6956 6962 +6
+ Misses 6072 6067 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
A slight reorganization of the tests into a Test Class, so that it's easier to reason about the tests. Also reduced the number of estimators to simplify tests slightly (runs slightly faster), fixed the `n_jobs=1` (would cause segmentation fault locally sometimes)
thatlittleboy
force-pushed
the
lightgbm-call-bug
branch
from
d23cbd5
to
f6975af
Compare
dsgibbons
reviewed
May 30, 2023
dsgibbons
approved these changes
May 31, 2023
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The commits can be reviewed individually. In short,
lightgbmtests into a TestClass to separate them from the xgboost, catboost etc. tests..shap_values()function call (without first converting to numpy array).Resolves #66 (read the issue for a background).
Related to issue slundberg#2144 (the original issue), and port of PR slundberg#2166 (but I implemented in a different way).