Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lightgbm call with categoricals bug #88

Merged
merged 5 commits into from
May 31, 2023
Merged

fix: lightgbm call with categoricals bug #88

merged 5 commits into from
May 31, 2023

Commits on May 29, 2023

  1. refactor lightgbm tests to a Test Class 

    A slight reorganization of the tests into a Test Class, so that it's
easier to reason about the tests.

Also reduced the number of estimators to simplify tests slightly (runs
slightly faster),
fixed the `n_jobs=1` (would cause segmentation fault locally sometimes)
    @thatlittleboy
    thatlittleboy committed May 29, 2023
    Configuration menu
    Copy the full SHA
    396b66e View commit details
    Browse the repository at this point in the history

  2. add tests for lightgbm __call__

    @thatlittleboy
    thatlittleboy committed May 29, 2023
    Configuration menu
    Copy the full SHA
    7ca0ccf View commit details
    Browse the repository at this point in the history

  3. delay the conversion of X to numpy array in __call__

    @thatlittleboy
    thatlittleboy committed May 29, 2023
    Configuration menu
    Copy the full SHA
    53acf50 View commit details
    Browse the repository at this point in the history

  4. refactor: show the interaction symmetry explicitly

    @thatlittleboy
    thatlittleboy committed May 29, 2023
    Configuration menu
    Copy the full SHA
    36fcd55 View commit details
    Browse the repository at this point in the history

  5. chore: add changelog entry

    @thatlittleboy
    thatlittleboy committed May 29, 2023
    Configuration menu
    Copy the full SHA
    f6975af View commit details
    Browse the repository at this point in the history