✨ Produce "//" in web paths #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if it used to be already the case, users had to specify a larger than default size to be able to see paths containing a "//" into them. As "//" is crucial in paths and totally part of the spec, they need to be generated with our default size too. The current PR makes sure we have a better balance between number of segments in a path and length of the segments. Our previous version (with default size) used to sacrify the number of segments and to prefer longer one. We now mix both. Related to #4896
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 494f5a6:
|
|
👋 A preview of the new documentation is available at: http://662b575b8b83d48537252a61--dubzzz-fast-check.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4935 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 213 213
Lines 16283 16296 +13
Branches 2664 2667 +3
=======================================
+ Hits 15774 15787 +13
Misses 509 509
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if it used to be already the case, users had to specify a larger than default size to be able to see paths containing a "//" into them. As "//" is crucial in paths and totally part of the spec, they need to be generated with our default size too.
The current PR makes sure we have a better balance between number of segments in a path and length of the segments. Our previous version (with default size) used to sacrify the number of segments and to prefer longer one. We now mix both.
Related to #4896
Category:
Potential impacts: