Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Produce "//" in web paths #4935

Merged
merged 5 commits into from
Apr 26, 2024
Merged

✨ Produce "//" in web paths #4935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
21c69d6
✨ Produce "//" in web paths
dubzzz Apr 26, 2024
a0f5074
version
dubzzz Apr 26, 2024
1613f16
update doc
dubzzz Apr 26, 2024
b2c605b
update snaps
dubzzz Apr 26, 2024
494f5a6
snaps again
dubzzz Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .yarn/versions/f914e4ac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
releases:
fast-check: minor

declined:
- "@fast-check/ava"
- "@fast-check/jest"
- "@fast-check/vitest"
- "@fast-check/worker"
16 changes: 14 additions & 2 deletions packages/fast-check/src/arbitrary/_internals/builders/UriPathArbitraryBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type { Size } from '../helpers/MaxLengthFromMinLength';
import { webSegment } from '../../webSegment';
import { array } from '../../array';
import { segmentsToPathMapper, segmentsToPathUnmapper } from '../mappers/SegmentsToPath';
import { oneof } from '../../oneof';

/** @internal */
function sqrtSize(size: Size): [Size, Size] {
Expand All @@ -21,10 +22,21 @@ function sqrtSize(size: Size): [Size, Size] {
}

/** @internal */
export function buildUriPathArbitrary(resolvedSize: Size): Arbitrary<string> {
const [segmentSize, numSegmentSize] = sqrtSize(resolvedSize);
function buildUriPathArbitraryInternal(segmentSize: Size, numSegmentSize: Size): Arbitrary<string> {
return array(webSegment({ size: segmentSize }), { size: numSegmentSize }).map(
segmentsToPathMapper,
segmentsToPathUnmapper,
);
}

/** @internal */
export function buildUriPathArbitrary(resolvedSize: Size): Arbitrary<string> {
const [segmentSize, numSegmentSize] = sqrtSize(resolvedSize);
if (segmentSize === numSegmentSize) {
return buildUriPathArbitraryInternal(segmentSize, numSegmentSize);
}
return oneof(
buildUriPathArbitraryInternal(segmentSize, numSegmentSize),
buildUriPathArbitraryInternal(numSegmentSize, segmentSize),
);
}
112 changes: 15 additions & 97 deletions packages/fast-check/test/e2e/__snapshots__/NoRegression.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4998,104 +4998,22 @@ Execution summary:
`;

exports[`NoRegression > webPath 1`] = `
[Error: Property failed after 39 tests
{ seed: 42, path: "38:3:1:8:7:3:3:4:3:3:4", endOnFailure: true }
Counterexample: ["/%F0%AA%80%80"]
Shrunk 10 time(s)
[Error: Property failed after 2 tests
{ seed: 42, path: "1:1:2", endOnFailure: true }
Counterexample: ["//"]
Shrunk 2 time(s)
Got error: Property failed by returning false

Execution summary:
√ [""]
√ [""]
√ [""]
√ [""]
√ [""]
√ [""]
√ [""]
√ [""]
√ ["/VnAy7J*"]
√ [""]
√ [""]
√ ["/%F0%AF%A8%A94%F1%B9%A0%93o,"]
√ [""]
√ ["/s"]
√ ["/_1J7+HWJ"]
√ [""]
√ ["/rs%E1%BC%82iRu:%F0%96%A6%96T"]
√ [""]
√ ["/sd1_z5eON"]
√ ["/d"]
√ [""]
√ [""]
√ ["/J4"]
√ [""]
√ ["/U*q%F3%9F%84%9BN"]
√ ["/70O%F1%80%97%B7d"]
√ [""]
√ [""]
√ [""]
√ ["/ZQt"]
√ ["/+g@"]
√ ["/c(z"]
√ [""]
√ [""]
√ [""]
√ ["/E"]
√ ["/LzY0Xwu%F2%82%AB%B5"]
√ [""]
× ["/cJ%F0%AA%AC%A7&'i"]
× ["///%F2%8C%AD%96"]
. √ [""]
. √ ["/"]
. √ ["/&'i"]
. × ["/J%F0%AA%AC%A7&'i"]
. . √ [""]
. . × ["/%F0%AA%AC%A7&'i"]
. . . √ [""]
. . . √ ["/&'i"]
. . . √ ["/%20&'i"]
. . . √ ["/%F0%95%A6%94&'i"]
. . . √ ["/%F0%A0%89%9E&'i"]
. . . √ ["/%F0%A5%9B%83&'i"]
. . . √ ["/%F0%A8%83%B5&'i"]
. . . √ ["/%F0%A9%98%8E&'i"]
. . . × ["/%F0%AA%82%9B&'i"]
. . . . √ [""]
. . . . √ ["/'i"]
. . . . √ ["/&'i"]
. . . . √ ["/%F0%A9%AD%95&'i"]
. . . . √ ["/%F0%A9%B7%B8&'i"]
. . . . √ ["/%F0%A9%BD%8A&'i"]
. . . . √ ["/%F0%A9%BF%B3&'i"]
. . . . × ["/%F0%AA%81%87&'i"]
. . . . . √ [""]
. . . . . √ ["/'i"]
. . . . . √ ["/&'i"]
. . . . . × ["/%F0%AA%80%9D&'i"]
. . . . . . √ [""]
. . . . . . √ ["/'i"]
. . . . . . √ ["/&'i"]
. . . . . . × ["/%F0%AA%80%88&'i"]
. . . . . . . √ [""]
. . . . . . . √ ["/'i"]
. . . . . . . √ ["/&'i"]
. . . . . . . √ ["/%F0%A9%BF%BE&'i"]
. . . . . . . × ["/%F0%AA%80%83&'i"]
. . . . . . . . √ [""]
. . . . . . . . √ ["/'i"]
. . . . . . . . √ ["/&'i"]
. . . . . . . . × ["/%F0%AA%80%81&'i"]
. . . . . . . . . √ [""]
. . . . . . . . . √ ["/'i"]
. . . . . . . . . √ ["/&'i"]
. . . . . . . . . × ["/%F0%AA%80%80&'i"]
. . . . . . . . . . √ [""]
. . . . . . . . . . √ ["/'i"]
. . . . . . . . . . √ ["/&'i"]
. . . . . . . . . . √ ["/%F0%A9%BF%BF&'i"]
. . . . . . . . . . × ["/%F0%AA%80%80"]
. . . . . . . . . . . √ [""]
. . . . . . . . . . . √ ["/"]
. . . . . . . . . . . √ ["/%F0%A9%BF%BF"]]
. × ["//%F2%8C%AD%96"]
. . √ ["/%F2%8C%AD%96"]
. . √ ["/"]
. . × ["//"]
. . . √ ["/"]
. . . √ ["/"]]
`;

exports[`NoRegression > webQueryParameters 1`] = `
Expand Down Expand Up @@ -5214,9 +5132,9 @@ Shrunk 4 time(s)
Got error: Property failed by returning false

Execution summary:
× ["http://e.pv/p%EF%8D%9D"]
. × ["http://a.pv/p%EF%8D%9D"]
. . × ["http://a.av/p%EF%8D%9D"]
. . . × ["http://a.aa/p%EF%8D%9D"]
× ["http://e.pv//"]
. × ["http://a.pv//"]
. . × ["http://a.av//"]
. . . × ["http://a.aa//"]
. . . . × ["http://a.aa"]]
`;
216 changes: 216 additions & 0 deletions packages/fast-check/test/unit/arbitrary/__snapshots__/webPath.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,221 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`webPath (integration) > should be able to shrink '//az' 1`] = `
""//az"
├> ""
├> "/az"
| ├> ""
| ├> "/"
| | └> ""
| ├> "/z"
| | ├> ""
| | ├> "/"
| | | └> ""
| | ├> "/a"
| | | ├> ""
| | | └> "/"
| | | └> ""
| | ├> "/n"
| | | ├> ""
| | | ├> "/"
| | | | └> ""
| | | ├> "/h"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | ├> "/e"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | ├> "/c"
| | | | | | ├> ""
| | | | | | ├> "/"
| | | | | | | └> ""
| | | | | | └> "/b"
| | | | | | ├> ""
| | | | | | ├> "/"
| | | | | | | └> ""
| | | | | | └> "/a"
| | | | | | ├> ""
| | | | | | └> "/"
| | | | | | └> ""
| | | | | └> "/d"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | └> "/c"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | ├> "/a"
| | | | | | ├> ""
| | | | | | └> "/"
| | | | | | └> ""
| | | | | └> "/b"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | └> "/a"
| | | | | ├> ""
| | | | | └> "/"
| | | | | └> ""
| | | | └> "/g"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | └> "/f"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | └> "/e"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | ├> "/a"
| | | | | ├> ""
| | | | | └> "/"
| | | | | └> ""
| | | | ├> "/c"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | └> "/b"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | └> "/a"
| | | | | ├> ""
| | | | | └> "/"
| | | | | └> ""
| | | | └> "/d"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | └> "/c"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | ├> "/a"
| | | | | ├> ""
| | | | | └> "/"
| | | | | └> ""
| | | | └> "/b"
| | | | ├> ""
| | | | └> …
| | | └> …
| | └> …
| └> …
└> …"
`;

exports[`webPath (integration) > should be able to shrink '/a//z' 1`] = `
""/a//z"
├> ""
├> "//z"
| ├> "/z"
| | ├> ""
| | ├> "/"
| | | └> ""
| | ├> "/a"
| | | ├> ""
| | | └> "/"
| | | └> ""
| | ├> "/n"
| | | ├> ""
| | | ├> "/"
| | | | └> ""
| | | ├> "/h"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | ├> "/e"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | ├> "/c"
| | | | | | ├> ""
| | | | | | ├> "/"
| | | | | | | └> ""
| | | | | | └> "/b"
| | | | | | ├> ""
| | | | | | ├> "/"
| | | | | | | └> ""
| | | | | | └> "/a"
| | | | | | ├> ""
| | | | | | └> "/"
| | | | | | └> ""
| | | | | └> "/d"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | └> "/c"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | ├> "/a"
| | | | | | ├> ""
| | | | | | └> "/"
| | | | | | └> ""
| | | | | └> "/b"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | └> "/a"
| | | | | ├> ""
| | | | | └> "/"
| | | | | └> ""
| | | | └> "/g"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | └> "/f"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | └> "/e"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | ├> "/a"
| | | | | ├> ""
| | | | | └> "/"
| | | | | └> ""
| | | | ├> "/c"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | └> "/b"
| | | | | ├> ""
| | | | | ├> "/"
| | | | | | └> ""
| | | | | └> "/a"
| | | | | ├> ""
| | | | | └> "/"
| | | | | └> ""
| | | | └> "/d"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | └> "/c"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | ├> "/a"
| | | | | ├> ""
| | | | | └> "/"
| | | | | └> ""
| | | | └> "/b"
| | | | ├> ""
| | | | ├> "/"
| | | | | └> ""
| | | | └> "/a"
| | | | └> …
| | | └> …
| | └> …
| └> …
└> …"
`;

exports[`webPath (integration) > should be able to shrink '/a/z' 1`] = `
""/a/z"
├> ""
Expand Down
Loading