[C API] Add static linking for WIN32 #13744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/include/duckdb.h
|
Initial discussion here: #2774 |
samansmink
reviewed
Sep 4, 2024
|
Yes, if you could close that one, I'd appreciate it. I based this PR on your initial changes and just moved them into the template. Otherwise, you can also move these changes (and the feedback) into your PR; both are fine by me. 😄 |
taniabogatsch
commented
Sep 4, 2024
|
The MIngW build is failing; I'll have a look tomorrow. |
|
Okay, somehow we need |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 10, 2024
Merge pull request duckdb/duckdb#13744 from taniabogatsch/c-api-for-win-fix
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 10, 2024
Merge pull request duckdb/duckdb#13744 from taniabogatsch/c-api-for-win-fix Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #12709 integrating the changes of @JAicewizard into the new C API generation scripts.