Add support for windows #248
Conversation
|
Amazing, thanks for working on this! I've moved some of your changes in duckdb to a new PR here to (hopefully) include them in the upcoming release: duckdb/duckdb#13744 |
There was a problem hiding this comment.
Hi @JAicewizard, thanks a lot for having a go at this! I've left some comments and questions.
taniabogatsch
added
[OS] Windows
# Conflicts: # .github/workflows/tests.yaml # deps/darwin_amd64/libduckdb.a # deps/darwin_arm64/libduckdb.a # deps/freebsd_amd64/libduckdb.a # duckdb.h # duckdb_test.go
|
Here are some updates on this PR. W.r.t. this comment #228, we should move to build the For other extensions, they won't be available for the Windows build (yet). I will add a note to the
W.r.t., the second option, DuckDB, already builds MinGW extensions for R here: https://github.com/duckdb/duckdb/blob/main/.github/workflows/R.yml. |
|
@taniabogatsch any updates for this? We are waiting for this PR :) Thanks. |
|
Thanks for the ping - I'll merge the most recent changes and rerun everything. 🤞 |
# Conflicts: # .github/workflows/tests.yaml # README.md # deps/darwin_amd64/libduckdb.a # deps/darwin_arm64/libduckdb.a # deps/freebsd_amd64/libduckdb.a # deps/linux_amd64/libduckdb.a # deps/linux_arm64/libduckdb.a
# Conflicts: # deps/darwin_amd64/libduckdb.a # deps/darwin_arm64/libduckdb.a # deps/windows_amd64/libduckdb.a
Pretty self-explanatory, this adds support for windows.
There are a couple issues, notably that duckdb doesn't build many extensions for mingw on windows. For this reason, I decided to statically link the json extension, as it feels essential. This leads to some platform differences, as explicitly installing/loading the json extension will result in an error.