Android: Should we clean up the replyProxyMap ?

[anikiki]

Task/Issue URL: https://app.asana.com/0/1200581511062568/1208338167068018/f

Description

Cleaned up the reply proxy maps when page changed.

Steps to test this PR

• Apply the below patch.

Subject: [PATCH] All the changes
---
Index: app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt b/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
--- a/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt	(revision 9c5253f0829e80e45700d077a62054cec1781b3e)
+++ b/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt	(date 1726845240094)
@@ -1329,8 +1329,10 @@
     }
 
     private fun cleanupBlobDownloadReplyProxyMaps() {
+        Timber.d("Before Cleaning up blob download reply proxy maps: replyProxyMap=$replyProxyMap fixedReplyProxyMap=$fixedReplyProxyMap")
         fixedReplyProxyMap.clear()
         replyProxyMap.clear()
+        Timber.d("After Cleaning up blob download reply proxy maps: replyProxyMap=$replyProxyMap fixedReplyProxyMap=$fixedReplyProxyMap")
     }
 
     private fun setAdClickActiveTabData(url: String?) {

• Install from this branch.
• Filter the logs by Cleaning up blob download.
• Navigate on various websites in the same tab and check the message appears with every page changed and the maps are cleared if they had values. Navigation examples: Load URL, Tap on links in the currently loaded website, Use Back and Forward from the menu, etc.
• Verify https://app.asana.com/0/1202552961248957/1206811138963758/f still works.

NO UI changes

[anikiki]

• Android: Should we clean up the replyProxyMap ? #5048 👈
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @anikiki and the rest of your teammates on Graphite