Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Should we clean up the replyProxyMap ? #5048

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+7 −0
Open

Android: Should we clean up the replyProxyMap ? #5048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,6 +1240,8 @@ class BrowserTabViewModel @Inject constructor(
title: String?,
) {
Timber.v("Page changed: $url")
cleanupBlobDownloadReplyProxyMaps()

hasCtaBeenShownForCurrentPage.set(false)
buildSiteFactory(url, title, urlUnchangedForExternalLaunchPurposes(site?.url, url))
setAdClickActiveTabData(url)
Expand Down Expand Up @@ -1326,6 +1328,11 @@ class BrowserTabViewModel @Inject constructor(
}
}

private fun cleanupBlobDownloadReplyProxyMaps() {
fixedReplyProxyMap.clear()
replyProxyMap.clear()
}

private fun setAdClickActiveTabData(url: String?) {
val sourceTabId = tabRepository.liveSelectedTab.value?.sourceTabId
val sourceTabUrl = tabRepository.liveTabs.value?.firstOrNull { it.tabId == sourceTabId }?.url
Expand Down
Loading