Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create base branch for behavioral toast report #5171

Draft
wants to merge 36 commits into
base: develop
Choose a base branch
from
Draft

Create base branch for behavioral toast report #5171

wants to merge 36 commits into from
+1,216 −21

Conversation

CrisBarreiro
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1208572899338519/f

Description

Steps to test this PR

Feature 1

  • [ ]
  • [ ]

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@CrisBarreiro Graphite App
Copy link
Contributor Author

CrisBarreiro commented Oct 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

This was referenced Oct 22, 2024
Merged
Merged
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/base branch 2 times, most recently from 858bb0f to 54fffec Compare October 29, 2024 09:32
@CrisBarreiro CrisBarreiro mentioned this pull request Oct 30, 2024
Merged
8 tasks
@CrisBarreiro CrisBarreiro mentioned this pull request Oct 31, 2024
Merged
50 tasks
@CrisBarreiro CrisBarreiro mentioned this pull request Nov 5, 2024
Merged
2 tasks
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/base branch 4 times, most recently from 0598f61 to 91ca637 Compare November 8, 2024 11:34
@CrisBarreiro CrisBarreiro mentioned this pull request Nov 8, 2024
Open
@lmac012 lmac012 self-assigned this Nov 13, 2024
@lmac012 lmac012 self-requested a review November 13, 2024 12:26
lmac012
lmac012 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@lmac012 lmac012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CrisBarreiro
Only show broken site prompt if RC is on
ce27425
@CrisBarreiro
Add click logic
3439917
@CrisBarreiro
Remove pixels
454e6e0
@CrisBarreiro
Fix buttons margin
f658c6a
@CrisBarreiro
Fix CI issues
ad7488d
@CrisBarreiro
Fix failing test
db69dee
@CrisBarreiro
Make isFeatureEnabled a suspend function
edd2f94
@CrisBarreiro
Fix banner background
bf98a60
@CrisBarreiro
Migrate from StateFlow to Flow
536072f
@CrisBarreiro
Handle user refreshes
31d52de
@CrisBarreiro
Fix dialog not being dismissed when switching tabs or navigating via …
1e1b685 
…omnibar
@CrisBarreiro
Determine refreshes using URL comparison
22b7cd4
@CrisBarreiro
Fix tests
96238c7
@CrisBarreiro
Rename method
858e947
@CrisBarreiro
Do not show prompt on DDG sites
f6fceef
@CrisBarreiro
Simplify testing
27acdc0
@CrisBarreiro
Fix tests
9e7dbe7
@CrisBarreiro
Remove comment
6b9fc4a
@CrisBarreiro
Add logs and remove testing tweaks
78cad66
@CrisBarreiro
Fix tests
f1e422a
@CrisBarreiro
Fix dismiss streak
22f757a
@CrisBarreiro
Dismiss prompt when URL changed
917ec13
@CrisBarreiro
Remove debug/test logs
55b8a0f
@CrisBarreiro
Disable old protections popup
e2dfdda
@CrisBarreiro
Add pixels and remove ATB
22a078c
@CrisBarreiro
Test pixels fired
371aaff
@CrisBarreiro
Remove m prefix from pixel
c6da822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmac012 lmac012 lmac012 approved these changes

Assignees

@lmac012 lmac012

Labels
STACKED PR - DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrisBarreiro @lmac012