Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle user refreshes #5213

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Oct 30, 2024

Task/Issue URL: https://app.asana.com/0/1204920898013511/1208572901396836/f

Description

Steps to test this PR

pre-requisites: Onboarding is completed, brokenSitePrompt RC flag is on (needs app restart)

Feature 1

  • Load a site
  • Quickly refresh 3 times
  • Check prompt is shown

Feature 1

  • Load a site
  • Quickly refresh 3 times
  • Check prompt is shown
  • Click on a link on that site
  • Check prompt is dismissed

Copy link
Contributor Author

CrisBarreiro commented Oct 30, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

@CrisBarreiro CrisBarreiro mentioned this pull request Oct 30, 2024
12 tasks
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/handle-user-refreshes branch from 084d33c to d248f95 Compare October 30, 2024 12:07
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-toast-ui branch from 6284500 to e57d6a0 Compare October 31, 2024 10:19
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/handle-user-refreshes branch from d248f95 to e3773d3 Compare October 31, 2024 10:19
@CrisBarreiro CrisBarreiro marked this pull request as ready for review October 31, 2024 11:37
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/handle-user-refreshes branch from 125add1 to ac4eadf Compare October 31, 2024 14:59
@CrisBarreiro CrisBarreiro mentioned this pull request Oct 31, 2024
50 tasks
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-toast-ui branch from e57d6a0 to b83bc3f Compare November 5, 2024 11:25
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/handle-user-refreshes branch from ac4eadf to d7ba8f3 Compare November 5, 2024 11:25
@CrisBarreiro CrisBarreiro mentioned this pull request Nov 5, 2024
2 tasks
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/handle-user-refreshes branch from d7ba8f3 to b2cb4ea Compare November 6, 2024 12:22
Copy link
Contributor

@lmac012 lmac012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-toast-ui branch from 1b16248 to 3b7b3ba Compare November 7, 2024 08:42
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/handle-user-refreshes branch from b2cb4ea to b658dfe Compare November 7, 2024 08:42
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-toast-ui branch from 3b7b3ba to d8ad11e Compare November 7, 2024 09:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/handle-user-refreshes branch from b658dfe to f82d425 Compare November 7, 2024 09:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-toast-ui branch from d8ad11e to cde1268 Compare November 7, 2024 14:46
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/handle-user-refreshes branch from f82d425 to e8f7eea Compare November 7, 2024 14:47
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-toast-ui branch from cde1268 to 2162998 Compare November 7, 2024 15:48
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/handle-user-refreshes branch from e8f7eea to c98fded Compare November 7, 2024 15:48
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-toast-ui branch from 2162998 to fee4c7f Compare November 7, 2024 17:19
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/handle-user-refreshes branch from c98fded to 9657cd1 Compare November 7, 2024 17:20
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/add-toast-ui branch from fee4c7f to c91ebca Compare November 7, 2024 17:29
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/broken-site/handle-user-refreshes branch from 9657cd1 to d3bbae9 Compare November 7, 2024 17:29
Base automatically changed from feature/cris/broken-site/add-toast-ui to feature/cris/broken-site/base November 7, 2024 17:30
@CrisBarreiro CrisBarreiro merged commit d3bbae9 into feature/cris/broken-site/base Nov 7, 2024
4 of 5 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cris/broken-site/handle-user-refreshes branch November 7, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants