Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enc, nonce and R from the hash of a note #123

Closed
xevisalle opened this issue Jan 30, 2023 · 0 comments · Fixed by #124
Closed

Remove enc, nonce and R from the hash of a note #123

xevisalle opened this issue Jan 30, 2023 · 0 comments · Fixed by #124
Assignees
@xevisalle

Comments

@xevisalle
Copy link
Member

Currently, when we compute the hash of a note (in the circuit and in the Merkle tree of notes), we include the parameters named enc, nonce, and R (where R is a part of the stealth address). We figured that these three elements are not needed in this computation. Hence, they can be removed from the circuit. This change will affect the circuit and the storage of notes in the Merkle tree of notes.
@xevisalle xevisalle self-assigned this Jan 30, 2023
@xevisalle xevisalle linked a pull request Jan 30, 2023 that will close this issue
Remove enc, R and nonce from note hash #124
Merged
@ureeves ureeves mentioned this issue May 17, 2023
Merged
@moCello moCello mentioned this issue Jul 4, 2023
Merged
moCello added a commit to dusk-network/rusk that referenced this issue Jul 6, 2023
@moCello
transfer-circuit: Update dependencies
3392b3e 
See also:
plonk issue [#717](dusk-network/plonk#717)
phoenix-core issue [#123](dusk-network/phoenix#123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xevisalle xevisalle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove enc, R and nonce from note hash dusk-network/phoenix
1 participant
@xevisalle