-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plonk to 0.14 #942
Merged
Merged
Update plonk to 0.14 #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/929_update_plonk
branch
6 times, most recently
from
July 5, 2023 19:36
3bdd08a
to
801f509
Compare
moCello
force-pushed
the
mocello/929_update_plonk
branch
2 times, most recently
from
July 6, 2023 09:46
9208000
to
ca5ca44
Compare
herr-seppia
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just amend commit messages to properly prefix crates
moCello
force-pushed
the
mocello/929_update_plonk
branch
from
July 6, 2023 10:23
ca5ca44
to
8027daa
Compare
See also plonk issue [#717](dusk-network/plonk#717)
See also: plonk issue [#717](dusk-network/plonk#717) phoenix-core issue [#123](dusk-network/phoenix#123)
moCello
force-pushed
the
mocello/929_update_plonk
branch
from
July 6, 2023 10:45
8027daa
to
2702de4
Compare
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to plonk v0.14 causes a version bump across the majority of our stack.
Notable changes:
Plonk
Prover
andVerifier
aren't generic over a circuit anymorePhoenix-core
enc
,R
andnonce
from note hash phoenix-core #123Merkle