Skip to content

Commit

Permalink
Merge pull request #86 from dwyl/update-to-node-v20-issue-#85
Browse files Browse the repository at this point in the history
PR: Update to `Node v20` issue #85
  • Loading branch information
asntc committed Jan 23, 2024
2 parents b3ace4a + 48af64b commit 8de1fd5
Show file tree
Hide file tree
Showing 6 changed files with 3,910 additions and 15 deletions.
8 changes: 8 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
version: 2
updates:
- package-ecosystem: npm
directory: "/"
schedule:
interval: weekly
time: "17:00"
timezone: Europe/London
39 changes: 39 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# This workflow will do a clean install of node dependencies, cache/restore them, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: Node.js CI

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [18.x, 20.x, 21.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
- name: Pre Flight Checks
run: |
mkdir tmp
chmod 777 tmp
echo "export HELLO=world" >> .env
cat .env
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: npm ci
# - run: npm run lint
- run: npm test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Deploy your AWS Lambda function(s) in seconds with a single command.

[![Build Status](https://img.shields.io/travis/dwyl/aws-lambda-deploy/master.svg?style=flat-square)](https://travis-ci.org/dwyl/aws-lambda-deploy)
[![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/dwyl/aws-lambda-deploy/ci.yml?label=build&style=flat-square&branch=main)](https://github.com/dwyl/aws-lambda-deploy/actions)
[![codecov.io](https://img.shields.io/codecov/c/github/dwyl/aws-lambda-deploy/master.svg?style=flat-square)](http://codecov.io/github/dwyl/aws-lambda-deploy?branch=master)
[![Code Climate maintainability](https://img.shields.io/codeclimate/maintainability/dwyl/aws-lambda-deploy?color=brightgreen&style=flat-square)](https://codeclimate.com/github/dwyl/aws-lambda-deploy)
[![dependencies Status](https://david-dm.org/dwyl/aws-lambda-deploy/status.svg?style=flat-square)](https://david-dm.org/dwyl/aws-lambda-deploy)
Expand Down
4 changes: 2 additions & 2 deletions lib/upload.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const utils = require('../lib/utils');
const basepath = utils.getBasepath();

/**
* upload does exacatly what you expect: uploads your lambda as a .zip to AWS!
* upload does exactly what you expect: uploads your lambda as a .zip to AWS!
* @param {Object} pkg - the package.json for the function you want to deploy
* this allows us to have a multi-lambda GitHub Repo or to deploy several Lambdas
* in one command by specifying the a different package.json for each of them.
Expand Down Expand Up @@ -41,7 +41,7 @@ function createParams (pkg) {
Role: process.env.AWS_IAM_ROLE,
MemorySize: pkg.lambda_memory ? parseInt(pkg.lambda_memory, 10) : 128, // https://git.io/vwt5y
Timeout: pkg.lambda_timeout ? parseInt(pkg.lambda_timeout, 10) : 10, // https://git.io/vrUhn
Runtime: 'nodejs12.x' // github.com/dwyl/aws-lambda-deploy/issues/65
Runtime: 'nodejs20.x' // github.com/dwyl/aws-lambda-deploy/issues/85 | 65
};
}

Expand Down
Loading

0 comments on commit 8de1fd5

Please sign in to comment.