Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update to Node v20 issue #85 #86

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Conversation

nelsonic
Copy link
Member

Busy updating this so that I can deploy a new lambda function ... πŸ§‘β€πŸ’» ⏳

@nelsonic
Copy link
Member Author

Getting the following lines not covered by tests:

image

πŸ˜•

@nelsonic
Copy link
Member Author

Also:

> nyc tape ./test/*.test.js | tap-nyc

    - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
    | process.env.TMPDIR: /Users/n/code/aws-lambda-deploy/tmp/
    | where dpl will temporarily store the Lambda Function zip file.
    - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
(node:15914) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

@nelsonic
Copy link
Member Author

On localhost I get:

    =============================== Coverage summary ===============================
    Statements   : 100% ( 142/142 )
    Branches     : 100% ( 30/30 )
    Functions    : 100% ( 27/27 )
    Lines        : 100% ( 141/141 )
    ================================================================================

  total:     41
  passing:   41

  duration:  2m 41.6s

I've added the .env vars to GitHub: https://github.com/dwyl/aws-lambda-deploy/settings/secrets/actions

@nelsonic
Copy link
Member Author

I think this needs to be merged into main for the GitHub Actions to start working ... πŸ’­

Copy link
Member

@asntc asntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. πŸ‘Œ

@asntc asntc merged commit 8de1fd5 into main Jan 23, 2024
@asntc asntc deleted the update-to-node-v20-issue-#85 branch January 23, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants