Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export TestDouble Function in Hex Package #44

Closed
nelsonic opened this issue Apr 3, 2020 · 1 comment
Closed

Export TestDouble Function in Hex Package #44

nelsonic opened this issue Apr 3, 2020 · 1 comment
Assignees
@nelsonic
Labels
enhancement T25m technical

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 3, 2020

Similar to dwyl/elixir-auth-google#35 we need to export the TestDouble for the GitHub auth so that we do not duplicate it. See code: dwyl/elixir-auth-google#36

This should only take one pomodoro to complete.
@nelsonic nelsonic self-assigned this Apr 3, 2020
nelsonic added a commit that referenced this issue Apr 3, 2020
@nelsonic
create inject_poison/0 function to enable TestDouble #44
42f4f1d
nelsonic added a commit that referenced this issue Apr 3, 2020
@nelsonic
remove TestDouble from coveralls.json as it is fully covered #44
f70a95e
nelsonic added a commit that referenced this issue Apr 3, 2020
@nelsonic
add test to cover HTTPoisonMock functions #44
72f749e
nelsonic added a commit that referenced this issue Apr 3, 2020
@nelsonic
add section on testing to README.md for #44
6dbaf4a
nelsonic added a commit that referenced this issue Apr 3, 2020
@nelsonic
bump version 1.1.0 > 1.1.1 for #44
6597e4e
@nelsonic nelsonic mentioned this issue Apr 3, 2020
Merged
2 tasks
nelsonic added a commit that referenced this issue Apr 3, 2020
@nelsonic
git rm config/* as no longer required #44
305a0d9
nelsonic added a commit that referenced this issue Apr 3, 2020
@nelsonic
return basic profile data in HTTPoisonMock.post!/4 for testing welcom…
8bd5c87 
…e template #44
nelsonic added a commit that referenced this issue Apr 3, 2020
@nelsonic
update instructions in readme to use login_url/1 #44
95c962e
SimonLab added a commit that referenced this issue Apr 3, 2020
@SimonLab
Merge pull request #45 from dwyl/export-testdouble-issue#44
797a991 
Create inject_poison/0 function to export TestDouble #44
@nelsonic
Copy link
Member Author

nelsonic commented Apr 3, 2020

PR: #45 merged by @SimonLab ✅

@nelsonic nelsonic closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
enhancement T25m technical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic