Export TestDouble issue #35 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 16 17 +1
=========================================
+ Hits 16 17 +1
Continue to review full report at Codecov.
|
…or clarity in stack trace #35
nelsonic
commented
Apr 2, 2020
| use Mix.Config | ||
|
|
||
| if Mix.env() == :test do | ||
| config :elixir_auth_google, httpoison: ElixirAuthGoogle.HTTPoison.InMemory |
There was a problem hiding this comment.
I've in-lined this in the lib/elixir_auth_google.ex @httpoison module attribute so we don't need the file. 👍 #35
|
@SimonLab this was easier than I thought. |
|
No further changes required. Got it working in my Auth PR: dwyl/auth#43 ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #35 I'm not a fan of having to duplicate Mock versions of the OAuth functions.
This PR introduces a transparent TestDouble which means the
AuthApp (and any other people) using this module no longer need to think about Mocking the requests.I think this will greatly improve the UX and our maintainability.
TestDouble) for Export TestDouble Function in Hex Package #35