Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Timers Don't Update When Start/Stop time is updated. #244

Closed
1 task done
nelsonic opened this issue Jan 4, 2023 · 2 comments · Fixed by #246
Closed
1 task done

Chore: Timers Don't Update When Start/Stop time is updated. #244

nelsonic opened this issue Jan 4, 2023 · 2 comments · Fixed by #246
Assignees
@LuchoTurtle
Labels
bug Suspected or confirmed bug (defect) in the code chore a tedious but necessary task often paying technical debt priority-1 Highest priority issue. This is costing us money every minute that passes. T1h Time Estimate 1 Hour tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Jan 4, 2023 •
edited by LuchoTurtle
Loading

At present when I update at timer.start or timer.stop is udpated, the value displayed is not updated:

mvp-timer-not-updating.mov

This quick screen recording demo that illustrates the point.
The timer should automatically re-render when the start or stop is updated.

Todo

  • fix this 🙏
@nelsonic nelsonic added bug Suspected or confirmed bug (defect) in the code technical A technical issue that requires understanding of the code, infrastructure or dependencies priority-1 Highest priority issue. This is costing us money every minute that passes. chore a tedious but necessary task often paying technical debt T1h Time Estimate 1 Hour tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written labels Jan 4, 2023
@nelsonic nelsonic moved this to 🔖 Ready for Development in dwyl app kanban Jan 4, 2023
LuchoTurtle added a commit that referenced this issue Jan 4, 2023
@LuchoTurtle
fix: Timer string updates after updating specific timer. #244
e3d7996
LuchoTurtle added a commit that referenced this issue Jan 4, 2023
@LuchoTurtle
fix: Updating BUILD file. #244
ee88765
@LuchoTurtle LuchoTurtle mentioned this issue Jan 4, 2023
Merged
LuchoTurtle added a commit that referenced this issue Jan 4, 2023
@LuchoTurtle
fix: Formatting files. #244
a2601b2
LuchoTurtle added a commit that referenced this issue Jan 4, 2023
@LuchoTurtle
fix: Fixing build file indentation. #244
fe9e324
@LuchoTurtle LuchoTurtle self-assigned this Jan 4, 2023
@LuchoTurtle LuchoTurtle moved this from 🔖 Ready for Development to 🏗 In progress in dwyl app kanban Jan 4, 2023
LuchoTurtle added a commit that referenced this issue Jan 17, 2023
@LuchoTurtle
Merge branch 'main' into fix-#244
21fba72
LuchoTurtle added a commit that referenced this issue Jan 17, 2023
@LuchoTurtle
fix: Updating with main branch and removing datetime_parser that is n…
e7e64a7 
…ot needed. #244
@LuchoTurtle
Copy link
Member

Should be fixed by #246

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in dwyl app kanban Jan 17, 2023
@nelsonic
Copy link
Member Author

Confirmed working for me on https://mvp.fly.dev/ ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuchoTurtle LuchoTurtle

Labels
bug Suspected or confirmed bug (defect) in the code chore a tedious but necessary task often paying technical debt priority-1 Highest priority issue. This is costing us money every minute that passes. T1h Time Estimate 1 Hour tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PR] Fixing timer string not updating after editing timer object dwyl/mvp
2 participants
@nelsonic @LuchoTurtle