[PR] Fixing timer string not updating after editing timer object

[LuchoTurtle]

fix #244

Item timer should now update accordingly.

[codecov]

Codecov Report

Merging #246 (33b5eb5) into main (9d57c7f) will increase coverage by 9.34%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #246      +/-   ##
===========================================
+ Coverage   90.65%   100.00%   +9.34%     
===========================================
  Files          15        14       -1     
  Lines         428       390      -38     
===========================================
+ Hits          388       390       +2     
+ Misses         40         0      -40     

Impacted Files	Coverage Δ
lib/app_web/live/app_live.ex	100.00% <100.00%> (+0.83%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[LuchoTurtle]

This line that is not covered is frustrating.

It clearly is covered by test/app_web/live/app_live_test.exs:522 (the diff is 15642000) but it fails because of formatting issues.

If I change the line in timer_text (the function where 'one line is not being covered') to

      s = if diff > 1000 do
          s = (diff / 1000) |> trunc()
          s = if s > 60, do: Integer.mod(s, 60), else: s
          left_pad(s)

the coverage is 100%.

But since the Github Action mandates the lines to be formatted, this line keeps popping off as "not covered" (and inconsistently, which is even more frustrating).

:(

[LuchoTurtle]

@nelsonic have you ever had this happen to you?
Having trouble circumventing this issue :/

[nelsonic]

Not had that issue before. Does it pass on your localhost? 💭

[LuchoTurtle]

Yes, it does.
It's an issue with how the formatted changes the if statement to a different line, coveralls doesn't "catch it", even though tests definitively cover it.

[nelsonic]

@SimonLab can you take a quick look at this? 🙏

[LuchoTurtle]

@nelsonic this PR should now be mergeable.

[nelsonic]

Thanks @LuchoTurtle 👍

Sadly the review app: https://mvp-pr-246.fly.dev/ is erroring:

But the code looks good and tests pass. 👌