Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add routes for API capture #53

Closed
2 tasks done
SimonLab opened this issue Dec 12, 2019 · 0 comments
Closed
2 tasks done

Add routes for API capture #53

SimonLab opened this issue Dec 12, 2019 · 0 comments
Assignees
Labels
awaiting-review An issue or pull request that needs to be reviewed enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes

Comments

@SimonLab
Copy link
Member

SimonLab commented Dec 12, 2019

To be able to test the capture feature (ie saving text in database) from dwyl/app#254 and https://github.com/dwyl/elm-pwa-example we need

  • the /api/capture endpoint which will receive a post request with json data text
{
  "capture": "capture text..."
}

The logic of the capture api endpoint will be similar to:
https://github.com/dwyl/app-mvp-phoenix/blob/d746db8bb33d874f6433550b865d47162b554fc6/lib/app_web/controllers/captures_controller.ex#L12-L22

We need to make sure the Ctx module can handle json

  • the /api/items/show endpoint which returns all the existing capture in a json format

https://github.com/dwyl/app-mvp-phoenix/blob/d746db8bb33d874f6433550b865d47162b554fc6/lib/app_web/controllers/item_controller.ex#L29-L32

@SimonLab SimonLab added enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes labels Dec 12, 2019
@SimonLab SimonLab self-assigned this Dec 12, 2019
@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Dec 12, 2019
SimonLab added a commit that referenced this issue Dec 12, 2019
@SimonLab SimonLab mentioned this issue Dec 12, 2019
1 task
SimonLab added a commit that referenced this issue Dec 13, 2019
SimonLab added a commit that referenced this issue Dec 13, 2019
@SimonLab SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Dec 13, 2019
@SimonLab SimonLab mentioned this issue Dec 13, 2019
3 tasks
@nelsonic nelsonic closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes
Projects
None yet
Development

No branches or pull requests

2 participants