Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Adding Papertrail and recording changes #255

Merged
merged 12 commits into from
Jan 12, 2023
Merged

[PR] Adding Papertrail and recording changes #255

merged 12 commits into from
Jan 12, 2023

Conversation

LuchoTurtle
Copy link
Member

@LuchoTurtle LuchoTurtle commented Jan 10, 2023 •
edited
Loading

closes #252

Integrates PaperTrail to track changes when updating/inserting items.

@LuchoTurtle LuchoTurtle added enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person elixir Pull requests that update Elixir code labels Jan 10, 2023
@LuchoTurtle LuchoTurtle self-assigned this Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023 •
edited
Loading

Codecov Report

Merging #255 (74b333d) into main (9b7c286) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #255   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          309       310    +1     
=========================================
+ Hits           309       310    +1
Impacted Files Coverage Δ
lib/app/item.ex 100.00% <100.00%> (ø)
lib/app_web/live/app_live.ex 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle
Copy link
Member Author

Guess the People table is a no-go #250 (comment)
Gonna change this tomorrow.

@nelsonic
Copy link
Member

@LuchoTurtle indeed. people table was removed in #118 ✅
Please rebase on main and it should be good to go. 👌

@nelsonic nelsonic added the merge-conflicts The branch or pull request has merge conflicts with the target branch (e.g. master) label Jan 11, 2023
@LuchoTurtle
Copy link
Member Author

@nelsonic should be mergeable.
The reason "the coverage dropped" is because of the "bug" of formatting that also occurs in #246 (comment) 😦

@LuchoTurtle LuchoTurtle requested a review from nelsonic January 11, 2023 10:44
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Jan 11, 2023
@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed merge-conflicts The branch or pull request has merge conflicts with the target branch (e.g. master) labels Jan 11, 2023
@nelsonic nelsonic removed the in-progress An issue or pull request that is being worked on by the assigned person label Jan 11, 2023
@nelsonic
Copy link
Member

Will take a look at this one next. 👌

@nelsonic nelsonic added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Jan 12, 2023
nelsonic
nelsonic approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle looks good. Thanks! 👌

@nelsonic nelsonic merged commit c811edb into main Jan 12, 2023
@nelsonic nelsonic deleted the papertrail-#252 branch January 12, 2023 21:51
@nelsonic nelsonic mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Add PaperTrail to MVP to enable item.text History!
2 participants
@LuchoTurtle @nelsonic