Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Fixing timer string not updating after editing timer object #246

Merged
merged 7 commits into from
Jan 17, 2023
Merged

[PR] Fixing timer string not updating after editing timer object #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e3d7996
fix: Timer string updates after updating specific timer. #244
LuchoTurtle Jan 4, 2023
ee88765
fix: Updating BUILD file. #244
LuchoTurtle Jan 4, 2023
a2601b2
fix: Formatting files. #244
LuchoTurtle Jan 4, 2023
fe9e324
fix: Fixing build file indentation. #244
LuchoTurtle Jan 4, 2023
21fba72
Merge branch 'main' into fix-#244
LuchoTurtle Jan 17, 2023
e7e64a7
fix: Updating with main branch and removing datetime_parser that is n…
LuchoTurtle Jan 17, 2023
33b5eb5
replace "users" with "clients"
nelsonic Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions BUILDIT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2938,8 +2938,13 @@ in the same file.
}

case Timer.update_timer_inside_changeset_list( timer, index, timer_changeset_list) do
{:ok, _list} -> {:noreply, assign(socket, editing: nil, editing_timers: [])}
{:error, updated_errored_list} -> {:noreply, assign(socket, editing_timers: updated_errored_list)}
{:ok, _list} ->
# Updates item list and broadcast to other clients
AppWeb.Endpoint.broadcast(@topic, "update", :update)
{:noreply, assign(socket, editing: nil, editing_timers: [])}

{:error, updated_errored_list} ->
{:noreply, assign(socket, editing_timers: updated_errored_list)}
end
end
```
Expand Down
198 changes: 0 additions & 198 deletions lib/app/datetime_parser.ex
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions lib/app_web/live/app_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ defmodule AppWeb.AppLive do
timer_changeset_list
) do
{:ok, _list} ->
# Updates item list and broadcast to other users
AppWeb.Endpoint.broadcast(@topic, "update", :update)
{:noreply, assign(socket, editing: nil, editing_timers: [])}

{:error, updated_errored_list} ->
Expand Down