Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update Phoenix 1.7 Rc ⬆️ #54

Closed
1 task
nelsonic opened this issue Dec 2, 2022 · 2 comments · Fixed by #55
Closed
1 task

Chore: Update Phoenix 1.7 Rc ⬆️ #54

nelsonic opened this issue Dec 2, 2022 · 2 comments · Fixed by #55
Assignees
@LuchoTurtle
Labels
chore priority-2 T4h technical

Comments

@nelsonic
Copy link
Member

nelsonic commented Dec 2, 2022

With the release of Phoenix 1.7 Rc dwyl/learn-phoenix#152 we can now update this tutorial to include a few enhancements. 🪄

Todo

  • Go through the tutorial from Scratch and re-create it with Phoenix 1.7 Rc
@nelsonic nelsonic pinned this issue Dec 2, 2022
@nelsonic nelsonic moved this to 🔖 Ready for Development in dwyl app kanban Dec 2, 2022
@nelsonic
Copy link
Member Author

nelsonic commented Dec 3, 2022

@LuchoTurtle as discussed on standup, please take a look at this. 🧑‍💻
Create a new branch and PR. 🙏

@nelsonic
Copy link
Member Author

nelsonic commented Dec 5, 2022

@LuchoTurtle feel free to nuke the project and start from scratch to avoid upgrade nightmares.
This project is using v1.5.3 which is pretty ancient at this point.

phoenix-todo-list-tutorial/mix.exs

Line 43 in e945ed2

{:phoenix, "~> 1.5.3"},

@nelsonic nelsonic mentioned this issue Dec 5, 2022
Closed
4 tasks
@LuchoTurtle LuchoTurtle moved this from 🔖 Ready for Development to 🏗 In progress in dwyl app kanban Dec 5, 2022
LuchoTurtle added a commit that referenced this issue Dec 5, 2022
@LuchoTurtle
feat: Initial commit with new app until repo. #54
b158abd
LuchoTurtle added a commit that referenced this issue Dec 5, 2022
@LuchoTurtle
fix: Fixing images and directories when adding MVP css. #54
7e06a4d
@LuchoTurtle LuchoTurtle mentioned this issue Dec 5, 2022
Merged
LuchoTurtle added a commit that referenced this issue Dec 6, 2022
@LuchoTurtle
feat: Fixing "Render _Real_ Data in the TodoMVC Layout" in readme. #54
2f880b8
LuchoTurtle added a commit that referenced this issue Dec 6, 2022
@LuchoTurtle
fix: Wip 5.0 readme section. #54
d277c82
LuchoTurtle added a commit that referenced this issue Dec 6, 2022
@LuchoTurtle
fix: Overriding project with Phoenix 1.7rc-based one. #54
8bcc323
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Finishing review of section 5. #54
3c04ee3
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Fixing Section 6 of readme. #54
32acb54
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Revising section 8 of readme. #54
bbaa6ca
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Fixing order of todos on completion. #54
7f6cb12
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Fixing delete issue. #54
a218903
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Fixing half os section 8 of readme. #54
3329d8f
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Finishing Section 8 in readme. #54
3d5d839
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Fixing section 10 of readme. #54
50cce48
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Fixing section 10 of readme. #54
22bd973
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Fixing section 11.1 on readme. #54
d56ba62
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Fixing section 11.2 on readme. #54
12e0c1c
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Fixing section 11.4 on readme. #54
142748d
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Adding turbo with section 11.5. #54
a341c2c
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Fixing permalinks on each example. #54
6649a67
LuchoTurtle added a commit that referenced this issue Dec 8, 2022
@LuchoTurtle
fix: Fixing typos and permalink. #54
812a42a
Repository owner moved this from 🏗 In progress to ✅ Done in dwyl app kanban Dec 9, 2022
@LuchoTurtle LuchoTurtle unpinned this issue Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuchoTurtle LuchoTurtle

Labels
chore priority-2 T4h technical
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PR] Phoenix 1.7rc upgrade dwyl/phoenix-todo-list-tutorial
2 participants
@nelsonic @LuchoTurtle