[PR] Phoenix 1.7rc upgrade #55

LuchoTurtle · 2022-12-05T18:04:53Z

closes #54

Still very much in progress. It's taking much longer than expected. The migration guide isn't really helping much, as I'm constantly getting stuck with routing.

The Routes.Helper isn't dynamically created no more and there are no instances of how to fix this in the guide, so I had to look in the docs for anything similar.

I'll keep on working 👍

LuchoTurtle · 2022-12-05T21:03:40Z

This is super frustrating.
I'm stuck on trying to render a component (new.html.heex) inside index.html.heex. I could simply just use the code inside it but that would go against the grain with the tutorial.

The old way was using <%= render "form.html", Map.put(assigns, :action, Routes.item_path(@conn, :create)) %> but there I can't find any mention of rendering .heex files inside other .heex files (component reusability)
https://hexdocs.pm/phoenix/1.7.0-rc.0/components.html

I really don't want to have to import Phoenix.View as dependency -> https://phoenixframework.org/blog/phoenix-1.7-released

I shouldn't need to... 😤

LuchoTurtle · 2022-12-06T09:37:38Z

Opened a question yesterday night but it was pending.
Got some answers after it got accepted during the night so I might give these a whirl.

https://elixirforum.com/t/how-to-use-embed-heex-inside-heex-phoenix-1-7rc/52281

(although I think only one is viable)

LuchoTurtle · 2022-12-06T10:40:28Z

Got it to work. Explained it here -> https://elixirforum.com/t/how-to-use-embed-heex-inside-heex-phoenix-1-7rc/52281/4?u=luchoturtle.

Calling <%= new(Map.put(assigns, :action, ~p"/items/new")) %> works and embeds the form properly.

Let's keep going...

nelsonic · 2022-12-06T10:44:06Z

Great that @t0t0's answer on Elixir Forum was helpful. 🎉
Really looking forward to seeing the progress on this PR. 👌
It's suuuuuuuper insightful to people considering using Phoenix how much has changed over the past 18 months. 💭

LuchoTurtle · 2022-12-06T23:27:38Z

Calling actions from the view seems to be the bane of my existence. It's super demotivating when nothing seems to work.
I truly have no idea why they would remove the ability to use Routes.item_path(@conn, :edit, item) to call actions from the template.
I thought <%= delete(Map.put(assigns, :action, ~p"/items/#{item.id}")) %> would work but it is not and it puts into question how the other one worked.
Spending two days on this is blasphemous and embarassing. Granted, the README will be updated accordingly but it's incredible how from 1.5 to 1.7 nothing works...

LuchoTurtle · 2022-12-06T23:49:30Z

...
And calling actions from the template.

Why does it work here?

<.table id="items" rows={@items} row_click={&JS.navigate(~p"/items/#{&1}")}>
  <:action :let={item}>
    <.link href={~p"/items/#{item}"} method="delete" data-confirm="Are you sure?">
      Delete
    </.link>
  </:action>
</.table>

And not simply?

   <.link
      class="destroy"
      navigate={~p"/items/#{item.id}"}
      method="delete"
    >
    </.link>

And if I want to use <:actions> by itself and try to make it work I get a
Invalid slot entry <:action>. A slot entry must be a direct child of a component. Looking for this error leads me here phoenixframework/phoenix_live_view#1892 but it really isn't all that helpful.

I mean, if I run mix phx.routes, I get the following output:

  GET     /                                      AppWeb.PageController :home
  GET     /items/toggle/:id                      AppWeb.ItemController :toggle
  GET     /items                                 AppWeb.ItemController :index
  GET     /items/:id/edit                        AppWeb.ItemController :edit
  GET     /items/new                             AppWeb.ItemController :new
  GET     /items/:id                             AppWeb.ItemController :show
  POST    /items                                 AppWeb.ItemController :create
  PATCH   /items/:id                             AppWeb.ItemController :update
  PUT     /items/:id                             AppWeb.ItemController :update
  DELETE  /items/:id                             AppWeb.ItemController :delete

Why isn't there a simple way of accessing /items/:id using the delete method? At this point I feel like I am almost forced to create a new route in router just to handle deleting files - but this shouldn't happen. It already works but why do I need to wrap anything in an element like a <.form> or <.table>? I shouldn't need to...

Here's the question I posted on Elixir Forums https://elixirforum.com/t/cant-get-delete-links-to-work-in-phoenix-1-7rc/52317

Sigh

nelsonic · 2022-12-07T01:01:45Z

Thank you for capturing your frustrations on this quest. 🙏
Keep going, you’re almost there! 🤞

LuchoTurtle · 2022-12-08T18:59:12Z

Finished updating all the README and all the permalinks in each step.
Haven't changed yet references to Heroku, though.
Will get with deploying to Fly.io and update this readme accordingly. That way I should close two issues with this PR at once.

LuchoTurtle · 2022-12-09T09:40:06Z

Assigning his over to @nelsonic . Need to get this merged in order to deploy it to Fly.io

nelsonic · 2022-12-09T11:40:38Z

lib/app/mailer.ex

@@ -0,0 +1,3 @@
+defmodule App.Mailer do


given that we aren't using mailer in this app, could we just delete this file? ✂️

Do you want me to delete these files? Why did you merge if you gave this feedback?

nelsonic · 2022-12-09T11:44:26Z

lib/app_web/components/core_components.ex

@@ -0,0 +1,621 @@
+defmodule AppWeb.CoreComponents do


This auto-generated file is massive. 😮
But at least it has good docs. 👍

nelsonic · 2022-12-09T11:45:05Z

lib/app_web/components/core_components.ex

+  JS commands may be passed to the `:on_cancel` and `on_confirm` attributes
+  for the caller to react to each button press, for example:
+
+      <.modal id="confirm" on_confirm={JS.push("delete")} on_cancel={JS.navigate(~p"/posts")}>


Modals are horrible in most cases, don't use them! dwyl/product-ux-research#38

nelsonic · 2022-12-09T11:45:53Z

lib/app_web/components/core_components.ex

+    )
+  end
+
+  def show_modal(js \\ %JS{}, id) when is_binary(id) do


nelsonic · 2022-12-09T11:47:39Z

priv/gettext/en/LC_MESSAGES/errors.po

@@ -50,13 +50,23 @@ msgid "are still associated with this entry"
 msgstr ""

 ## From Ecto.Changeset.validate_length/3
+msgid "should have %{count} item(s)"


are we actually using gettext for translating the UI? 💭
If so, we could add a whole new section to this tutorial! 💡

nelsonic · 2022-12-09T11:48:02Z

priv/gettext/en/LC_MESSAGES/errors.po

@@ -50,13 +50,23 @@ msgid "are still associated with this entry"
 msgstr ""

 ## From Ecto.Changeset.validate_length/3
+msgid "should have %{count} item(s)"


are we actually using gettext for translating the UI? 💭
If so, we could add a whole new section to this tutorial! 💡

nelsonic

@LuchoTurtle this is a great update. Nice work! 🎉

nelsonic

@LuchoTurtle this is a great update. Nice work! 🎉

LuchoTurtle added 2 commits December 5, 2022 10:35

feat: Initial commit with new app until repo. #54

b158abd

fix: Fixing images and directories when adding MVP css. #54

7e06a4d

LuchoTurtle added chore in-progress labels Dec 5, 2022

LuchoTurtle self-assigned this Dec 5, 2022

LuchoTurtle marked this pull request as draft December 5, 2022 18:05

feat: Fixing "Render _Real_ Data in the TodoMVC Layout" in readme. #54

2f880b8

LuchoTurtle added 2 commits December 6, 2022 09:53

fix: Wip 5.0 readme section. #54

d277c82

fix: Overriding project with Phoenix 1.7rc-based one. #54

8bcc323

LuchoTurtle added 3 commits December 6, 2022 13:08

fix: Finishing review of section 5. #54

3c04ee3

fix: Fixing Section 6 of readme. #54

32acb54

fix: Revising section 8 of readme. #54

bbaa6ca

LuchoTurtle added 11 commits December 7, 2022 09:54

fix: Fixing order of todos on completion. #54

7f6cb12

fix: Fixing delete issue. #54

a218903

fix: Fixing half os section 8 of readme. #54

3329d8f

fix: Finishing Section 8 in readme. #54

3d5d839

fix: Fixing section 10 of readme. #54

50cce48

fix: Fixing section 10 of readme. #54

22bd973

fix: Fixing section 11.1 on readme. #54

d56ba62

fix: Fixing section 11.2 on readme. #54

12e0c1c

fix: Fixing section 11.4 on readme. #54

142748d

fix: Adding turbo with section 11.5. #54

a341c2c

fix: Fixing permalinks on each example. #54

6649a67

fix: Fixing typos and permalink. #54

812a42a

LuchoTurtle requested a review from nelsonic December 9, 2022 09:39

LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Dec 9, 2022

LuchoTurtle marked this pull request as ready for review December 9, 2022 09:39

LuchoTurtle added awaiting-review and removed in-progress labels Dec 9, 2022

nelsonic added in-review enhancement technical and removed awaiting-review labels Dec 9, 2022

nelsonic reviewed Dec 9, 2022

View reviewed changes

lib/app_web/components/core_components.ex

)

end

def show_modal(js \\ %JS{}, id) when is_binary(id) do

Copy link

Member

nelsonic Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't.

nelsonic reviewed Dec 9, 2022

View reviewed changes

nelsonic approved these changes Dec 9, 2022

View reviewed changes

nelsonic merged commit 5a8e85f into main Dec 9, 2022

nelsonic deleted the phoenix-1.7rc branch December 9, 2022 12:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PR] Phoenix 1.7rc upgrade #55

[PR] Phoenix 1.7rc upgrade #55

LuchoTurtle commented Dec 5, 2022

LuchoTurtle commented Dec 5, 2022 •

edited

Loading

LuchoTurtle commented Dec 6, 2022

LuchoTurtle commented Dec 6, 2022

nelsonic commented Dec 6, 2022

LuchoTurtle commented Dec 6, 2022

LuchoTurtle commented Dec 6, 2022 •

edited

Loading

nelsonic commented Dec 7, 2022

LuchoTurtle commented Dec 8, 2022

LuchoTurtle commented Dec 9, 2022

nelsonic Dec 9, 2022

LuchoTurtle Dec 9, 2022

nelsonic Dec 9, 2022

nelsonic Dec 9, 2022

nelsonic Dec 9, 2022

nelsonic Dec 9, 2022

nelsonic Dec 9, 2022

nelsonic left a comment

nelsonic left a comment

[PR] Phoenix 1.7rc upgrade #55

[PR] Phoenix 1.7rc upgrade #55

Conversation

LuchoTurtle commented Dec 5, 2022

LuchoTurtle commented Dec 5, 2022 • edited Loading

LuchoTurtle commented Dec 6, 2022

LuchoTurtle commented Dec 6, 2022

nelsonic commented Dec 6, 2022

LuchoTurtle commented Dec 6, 2022

LuchoTurtle commented Dec 6, 2022 • edited Loading

nelsonic commented Dec 7, 2022

LuchoTurtle commented Dec 8, 2022

LuchoTurtle commented Dec 9, 2022

nelsonic Dec 9, 2022

Choose a reason for hiding this comment

LuchoTurtle Dec 9, 2022

Choose a reason for hiding this comment

nelsonic Dec 9, 2022

Choose a reason for hiding this comment

nelsonic Dec 9, 2022

Choose a reason for hiding this comment

nelsonic Dec 9, 2022

Choose a reason for hiding this comment

nelsonic Dec 9, 2022

Choose a reason for hiding this comment

nelsonic Dec 9, 2022

Choose a reason for hiding this comment

nelsonic left a comment

Choose a reason for hiding this comment

nelsonic left a comment

Choose a reason for hiding this comment

LuchoTurtle commented Dec 5, 2022 •

edited

Loading

LuchoTurtle commented Dec 6, 2022 •

edited

Loading