-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modals 🙅 #38
Comments
How about the native dialog element that is built into modern browsers now? This includes lot of usability and accessibility features built in: focus trapping, autofocus on element, inert on document, open and close method, automatic close on esc key. Example https://web.dev/building-a-dialog-component/ Scott o hara mentions using native dialog now
|
Hey @trickydisco78 👋 [how on earth did you find this issue?! 😜 ...] Yeah, Native dialogs have been available for a while: As noted in the second checkbox above, Modals are not the same as the Native I would still caution against using them liberally because unless they add to the UX. 🤷♂️ Yes, "focus trapping" is a potentially valid scenario ... @scottaohara is a good designer and his Highly recommend watching Bret Victor's "Inventing on Principle" "You can choose to sleepwalk through life
|
Hey.. I found it linked from discussions here: alphagov/govuk-design-system-backlog#30 As part of a project i've been asked to implement a modal. In this instance because of good support i've used the native dialog DOM element. I agree with you in a lot of respects. Modals are over used. But in others maybe not. Its a UI pattern that has been used for a long time: think of all the dialog modals that appear on mac and windows OS. They are everywhere! The same with Games: https://www.gameuidatabase.com/index.php?set=1&scrn=902&tag=8&r=1 same with apple Or maybe i'm getting confused about the difference between a dialog and a modal? A modal to me is when the background dims behind. I think you should have the ability to light dimiss (cick outside the modal) to close it. |
These are all examples of Native UI components which are extensively tested both for pixel-perfection and a11y. ✅ The Spotify's use of modals to interrupt the UX flow is particularly egregious! 😠 The gmail one is just horrible. It' adds no value whatsoever. it's just a UI/UX anti-pattern. 🤦♂️ Sadly,, I don't think this thread is the place I'm going to "convince" anyone especially given the ubiquity of modals ... |
not really sure why i was @'d in here? but since i was, i'll just quickly respond to
odd word choice to say i "failed" on something I never attempted to discuss. tbh, i actually agree with
but, i don't have the time or energy to fight that battle. Rather, it seems more important to me to help people know how to make them accessible for when they do use them. good luck to you though. hope you don't fail ;) |
@scottaohara apologies for spamming you. 🤦♂️ Love your work! Thank you all you do for Accessibility. ❤️ Just wanted to highlight that your project that has great docs 😍 Anyway, hope you're both having a great Friday! ☀️ |
How about this opinion https://twitter.com/anotheruiguy/status/1589743863325167616 Is there concensus on the difference between a modal and a dialog? Even the native dialog element has a showModal() event |
it's not really a matter of consensus. people either understand these terms, or they use "modal" incorrectly. |
This is the crap I think of whenever I think of Modals: An unwelcome interruption to the task I'm attempting to perform. [Researching: https://github.com/dwyl/workshop/issues/93 ...] |
There appears to be some confusion about what a The By contrast, the "Card" on git-fork "buy" page: https://git-fork.com/buy is not a It does hijack the focus of the person viewing the page. It's simply presented as the suggested focal point. Sadly, when you click on the Why?! 🤷♂️ |
I kind of disagree with your opinion on Fork's use of this modal. But what would the alternative be? Opening a new tab with the Paddle payment session? In terms of "time wasted (🙄)", I'd waste more time in changing windows and waiting for them to load. Should the session be changed within the same tab? It would be worse. If I wanted to go back, I would have to wait for the page to load again from the payment session checkout page. With this modal, I can just close it if I changed my mind about buying the product. Amazon being the most successful e-commerce in the world has nothing to do with how great or bad the shopping experience is (especially checking out when purchasing items). Here's an annoying example: Here's me wanting to purchase a Benjamin Tod vinyl. When I check out, I am navigated to an entirely different page just to fill in card details, etc... I find myself having to go back to add forgotten items or check other items countless times and I'm sure I've wasted more time loading Amazon's big website bundle when I could just have closed a modal and kept looking. Happy to hear opinions 👍 |
Everyone is very welcome to disagree with what I write. Ideally with evidence. 🙏 Does not use When it comes to They have run many Buuuuuuttttt ... if we are still curious. I've asked the questions in places we might get more data:
In e-commerce checkout We might not have the data from the
|
https://youtu.be/uXs-zPc63kM?t=3007 Ouch ... 📉Just don't do it! It's not worth it. |
So glad someone You don't need a modal window: https://youdontneedamodalwindow.dev/ via: https://news.ycombinator.com/item?id=36056376 sadly, most of the comments on HN are from hipsters who have never seen an accessibility study |
I think the "details" tag can be useful: click to view moreHere are the details you want to readI helps to keep the flow a bit more tidy. |
Yeah, nothing against the |
A
modal
was used in one of our tutorials https://github.com/dwyl/learn-alpine.js/pull/5/files#r1012307859I want to capture why we don't want to use them. ever.
Todo
The text was updated successfully, but these errors were encountered: