Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Commit

Permalink
merge main into feature (#544)
Browse files Browse the repository at this point in the history 
* [fix] handle version number format in package dependency (#507)

* update PMD to version 6.34.0. (#508)

The default PMD version is now 6.34.0.
The deprecated rules have been removed from
`pmd-ruleset.xml` and have been replaced by
the new rules equivalent.

* Update versions

* feat(source:pmd)!: output to stdout and add extra flags. (#516)

* feat(source:pmd)!: output to stdout and add extra flags.

BREAKING CHANGES:
 - The source:pmd command now output the result to stdout
by default. The "-reportfile" flag can be used to restore
the previous behaviour.
 - The command uses the same exit code as PMD. To always return
   0 regardless of the analysis result, use the `--no-failonviolation`
   flag

other changes:
 - --json flag now contains the analysis result.
 - add support for most of the PMD flags
 - deprecate `--report` in favour of `--reportfile`

fixes #514

```
This command is a wrapper around PMD ( downloads PMD for the first time) with some predefined defaults, such as ruleset, output format, output file.

USAGE
  $ sfdx sfpowerkit:source:pmd [-d <directory> | --filelist <filepath>] [-r <string>] [-f <string>] [--report <filepath> | -o <filepath>] [--javahome <string>] [--failonviolation] [--minimumpriority <integer>] [--shortnames] [--showsuppressed] [--suppressmarker <string>] [--version <string>] [--json] [--loglevel trace|debug|info|warn|error|fatal|TRACE|DEBUG|INFO|WARN|ERROR|FATAL]

OPTIONS
  -d, --directory=directory                                                         [default: Default project directory as mentioned in sfdx-project.json] Override this to set a different directory in the project folder
  -f, --format=format                                                               [default: text] [default: text] The format for the pmd output, Possible values are available at https://pmd.github.io/latest/pmd_userdocs_cli_reference.html#available-report-formats
  -o, --reportfile=reportfile                                                       [default: pmd-output] The path to where the output of the analysis should be written
  -r, --ruleset=ruleset                                                             [default: [sfpowerkit](https://github.com/Accenture/sfpowerkit/blob/main/resources/pmd-ruleset.xml)] The comma separated pmd ruleset that will be utilzied for analyzing the apex classes,  Checkout https://pmd.github.io/latest/pmd_userdocs_making_rulesets.html to create your own ruleset
  --[no-]failonviolation                                                            [default: true] By default PMD exits with status 4 if violations are found. Disable this feature with -failOnViolation false to exit with 0 instead and just output the report.
  --filelist=filelist                                                               Path to file containing a comma delimited list of files to analyze.
  --javahome=javahome                                                               The command will try to locate the javahome path to execute PMD automatically, set this flag to override it to another javahome path
  --json                                                                            format output as json
  --loglevel=(trace|debug|info|warn|error|fatal|TRACE|DEBUG|INFO|WARN|ERROR|FATAL)  [default: warn] logging level for this command invocation
  --minimumpriority=minimumpriority                                                 Rule priority threshold; rules with lower priority than configured here won't be used.
  --report=report                                                                   [default: pmd-output] DEPRECATED: use --reportfile instead.
  --[no-]shortnames                                                                 Prints shortened filenames in the report.
  --[no-]showsuppressed                                                             Causes the suppressed rule violations to be added to the report.
  --suppressmarker=suppressmarker                                                   [default: NOPMD] Specifies the comment token that marks lines which PMD should ignore.
  --version=version                                                                 [default: 6.34.0] [default: 6.34.0] The version of the pmd to be utilized for the analysis, this version will be downloaded to sfpowerkit's cache directory

EXAMPLE
  $ sfdx sfpowerkit:source:pmd
```

* feat(source:pmd): allow rulesets from PMD classpath.

This commit does not validate the location of the
given rulesets, as they can be in JAR files in PMD's
classpath.

Other changes:
 - fix handling of --javahome
 - deprecate '--ruleset' in favor of '--rulesets' to
 align with PMD CLI options
 - display warning when deprecated flags are used
 - refactor 'run()' to reduce its complexity
 - if java can't be run, the exit code is 1 and the
 appropriate error message is displayed

* chore: remove unused imports in pms.ts

Co-authored-by: Azlam <43767972+azlam-abdulsalam@users.noreply.github.com>

* Increment major version

* Automatically authorize a user fetching an org from a pool (#519)

* Saving Sfdx Auth Url if available

* Fix npm audit issues

* Add support for sfdxauthurl in fetch

* Add an option to disable auto open
* Fix not fetching when alias is not passed

* Remove intermediate authFile from repo

* Make fetched org act as scratch org

* Add option to set defaultorg

* Remove automatic opening

Co-authored-by: Azlam <azlam.abdulsalam@accenture.com>
Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale>

* Increment minor version

* fix:Issue #517 (#518)

Fix reconcile on Activity fields

Co-authored-by: Henry <henry88lay@gmail.com>

* Increment patch version

* Validate SFDX Auth URL (#523)

* Fix Alias for user mode (#521)

Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale>

* Increment versions

* [ci skip] Update new version id of the pool prerequisite package

* fix:IIssue #524 Profile reconcile (#528)

Happen when only one record returned for metadatatype.

* Fix undhandled error when package is missing in packageAliases (#534)

Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale>

* Bug: Packages in  mono repo getting installed (#533)

* Bug: Packages in  mono repo getting installed

Packages in the same repo can be added as a dependency
to another package, and it should be skipped as source
code of these packages are available. A bug was causing
all the packages to be installed if there was no existing
packages in the scratch org

* Fix Deepscan issues

Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale>

* Increment version

* Update dependencies

* Fixes #535 (#536)

* Increment version

* Update metadata coverage to 52

* Increment version

* Fix for Scratch Orgs Not created with JWT Bearer Flow (#543)

* Do not halt if the scratch org is created using JWT auth

* Use scratchOrg Object

Co-authored-by: azlam-abdulsalam <sfpowerscripts@dxscale>

* Increment version

* Issue/503 (#527)

* Set Up Initial Files

* commit changes

removed both releasedefintion and sfdx-project schema json files.
added the first converted tag mode config json schema

* changes and additions

corrected descriptions for tag mode schema
added user mode schema

* adjustments to the tag mode schema

* changes done

adjusted the schema to ensure the json pool configs are given types and refs

* nested the schema pools

* changes on array

changed keyword from items to contains

* changed pattern to format on ipaddress

* added additionalProperties false line on users and poolusers

* added required properties

* pr amendments 1

added descriptions
refined the required fields based on sfpowerkit doc.

* removed required: pool as not needed when validated against json schema

* added new file

setting up the new json file to consoldate both user and tag mode before deleting others

* removed these schemas as i have created a new one consolodating both

* drafted and validated the new schema

* Changes

moved soPoolConfigSchema.ts to src/impl/pool/scratchorg/
introduced a code to make validate SO in poolCreateImpl]

* fix:IIssue #524 Profile reconcile (#528)

Happen when only one record returned for metadatatype.

* Fix undhandled error when package is missing in packageAliases (#534)

Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale>

* Bug: Packages in  mono repo getting installed (#533)

* Bug: Packages in  mono repo getting installed

Packages in the same repo can be added as a dependency
to another package, and it should be skipped as source
code of these packages are available. A bug was causing
all the packages to be installed if there was no existing
packages in the scratch org

* Fix Deepscan issues

Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale>

* Increment version

* Update dependencies

* Fixes #535 (#536)

* Increment version

* Update metadata coverage to 52

* Increment version

* revert changes

revert changes on poolCreateImpl on generateScratchOrgs line 369 to 397
revert changes on README in scratchorgpool package code to previous.
revert previous commit on format on sfdx-project.json

* removed max allocation and script file path from required, tested and worked

* removed requestPromise required and trailing whitespace in poolCreateImpl

* Fix for Scratch Orgs Not created with JWT Bearer Flow (#543)

* Do not halt if the scratch org is created using JWT auth

* Use scratchOrg Object

Co-authored-by: azlam-abdulsalam <sfpowerscripts@dxscale>

* Increment version

* readded the correct changes and code that I missed when rebasing from main

* reverted selected changes from rebase

Co-authored-by: Genoud Magloire <magloiredjatio@gmail.com>
Co-authored-by: Azlam <43767972+azlam-abdulsalam@users.noreply.github.com>
Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale>
Co-authored-by: Matt Simonis <matt.simonis@communitybrands.com>

Co-authored-by: Mani <44075423+manisfdcsfdx@users.noreply.github.com>
Co-authored-by: Rodolphe Blancho <rodolphe.blancho@gmail.com>
Co-authored-by: Azlam <azlam.abdulsalam@accenture.com>
Co-authored-by: Azlam <43767972+azlam-abdulsalam@users.noreply.github.com>
Co-authored-by: Fabien Taillon <ftaillon@gmail.com>
Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale>
Co-authored-by: Genoud Magloire <magloiredjatio@gmail.com>
Co-authored-by: Henry <henry88lay@gmail.com>
Co-authored-by: Alan Ly <36793262+aly76@users.noreply.github.com>
Co-authored-by: Matt Simonis <matt.simonis@communitybrands.com>
  • Loading branch information
@Caitlyn-Mills @manisfdcsfdx
@rody @azlam-abdulsalam @FabienTaillon @genoud @henry88lay @aly76 @msimonis
11 people authored Jul 13, 2021
1 parent b5972d3 commit ebe5edd
Show file tree
Hide file tree
Showing 20 changed files with 2,689 additions and 4,747 deletions.
2 changes: 2 additions & 0 deletions messages/scratchorg_poolFetch.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,7 @@
"commandDescription": "Gets an active/unused scratch org from the scratch org pool",
"tagDescription": "(required) tag used to identify the scratch org pool",
"mypoolDescription": "Filter the tag for any additions created by the executor of the command",
"aliasDescription":"Fetch and set an alias for the org",
"setdefaultusernameDescription": "set the authenticated org as the default username that all commands run against",
"sendToUserDescription": "Send the credentials of the fetched scratchorg to another DevHub user, Useful for situations when pool is only limited to certain users"
}
17 changes: 12 additions & 5 deletions messages/source_pmd.json
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
{
"commandDescription": "This command is a wrapper around PMD ( downloads PMD for the first time) with some predefined defaults, such as ruleset, output format, output file. The command is to be run from the project directory",
"commandDescription": "This command is a wrapper around PMD ( downloads PMD for the first time) with some predefined defaults, such as ruleset, output format, output file.",
"javaHomeFlagDescription": "The command will try to locate the javahome path to execute PMD automatically, set this flag to override it to another javahome path",
"directoryFlagDescription": "[default: Default project directory as mentioned in sfdx-project.json] Override this to set a different directory in the project folder",
"rulesetFlagDescription": "[default: [sfpowerkit](https://github.com/Accenture/sfpowerkit/blob/main/resources/pmd-ruleset.xml)] The comma separated pmd ruleset that will be utilzied for analyzing the apex classes, Checkout https://pmd.github.io/latest/pmd_userdocs_making_rulesets.html to create your own ruleset",
"rulesetsFlagDescription": "[default: [sfpowerkit](https://github.com/Accenture/sfpowerkit/blob/main/resources/pmd-ruleset.xml)] The comma separated pmd ruleset that will be utilzied for analyzing the apex classes, Checkout https://pmd.github.io/latest/pmd_userdocs_making_rulesets.html to create your own ruleset",
"rulesetFlagDescription": "DEPRECATED: use --rulesets instead",
"formatFlagDescription": "[default: text] The format for the pmd output, Possible values are available at https://pmd.github.io/latest/pmd_userdocs_cli_reference.html#available-report-formats",
"reportFlagDescription": "[default: pmd-output] The path to where the output of the analysis should be written",
"supressoutputFlagDescription": "[default: false] Supress the ouptut of the analysis to be displayed in the console",
"versionFlagDescription": "[default: 6.30.0] The version of the pmd to be utilized for the analysis, this version will be downloaded to sfpowerkit's cache directory"
"filelistFlagDescription": "Path to file containing a comma delimited list of files to analyze.",
"reportFlagDescription": "DEPRECATED: [default: pmd-output] use --reportfile instead.",
"reportfileFlagDescription": "[default: pmd-output] The path to where the output of the analysis should be written",
"versionFlagDescription": "[default: 6.34.0] The version of the pmd to be utilized for the analysis, this version will be downloaded to sfpowerkit's cache directory",
"minimumpriorityFlagDescription": "Rule priority threshold; rules with lower priority than configured here won't be used.",
"shortnamesFlagDescription": "Prints shortened filenames in the report.",
"showsuppressedFlagDescription": "Causes the suppressed rule violations to be added to the report.",
"suppressmarkerFlagDescription": "[default: NOPMD] Specifies the comment token that marks lines which PMD should ignore.",
"failonviolationFlagDescription": "[default: true] By default PMD exits with status 4 if violations are found. Disable this feature with -failOnViolation false to exit with 0 instead and just output the report."
}
1,354 changes: 636 additions & 718 deletions npm-shrinkwrap.json
View file

Large diffs are not rendered by default.

Loading

0 comments on commit ebe5edd

Please sign in to comment.