This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
Bug: Packages in mono repo getting installed #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2021 10:27
Packages in the same repo can be added as a dependency to another package, and it should be skipped as source code of these packages are available. A bug was causing all the packages to be installed if there was no existing packages in the scratch org
henry88lay
pushed a commit
that referenced
this pull request
Jul 8, 2021
* Bug: Packages in mono repo getting installed Packages in the same repo can be added as a dependency to another package, and it should be skipped as source code of these packages are available. A bug was causing all the packages to be installed if there was no existing packages in the scratch org * Fix Deepscan issues Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale>
azlam-abdulsalam
added a commit
that referenced
this pull request
Jul 8, 2021
* Set Up Initial Files * commit changes removed both releasedefintion and sfdx-project schema json files. added the first converted tag mode config json schema * changes and additions corrected descriptions for tag mode schema added user mode schema * adjustments to the tag mode schema * changes done adjusted the schema to ensure the json pool configs are given types and refs * nested the schema pools * changes on array changed keyword from items to contains * changed pattern to format on ipaddress * added additionalProperties false line on users and poolusers * added required properties * pr amendments 1 added descriptions refined the required fields based on sfpowerkit doc. * removed required: pool as not needed when validated against json schema * added new file setting up the new json file to consoldate both user and tag mode before deleting others * removed these schemas as i have created a new one consolodating both * drafted and validated the new schema * Changes moved soPoolConfigSchema.ts to src/impl/pool/scratchorg/ introduced a code to make validate SO in poolCreateImpl] * fix:IIssue #524 Profile reconcile (#528) Happen when only one record returned for metadatatype. * Fix undhandled error when package is missing in packageAliases (#534) Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale> * Bug: Packages in mono repo getting installed (#533) * Bug: Packages in mono repo getting installed Packages in the same repo can be added as a dependency to another package, and it should be skipped as source code of these packages are available. A bug was causing all the packages to be installed if there was no existing packages in the scratch org * Fix Deepscan issues Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale> * Increment version * Update dependencies * Fixes #535 (#536) * Increment version * Update metadata coverage to 52 * Increment version * revert changes revert changes on poolCreateImpl on generateScratchOrgs line 369 to 397 revert changes on README in scratchorgpool package code to previous. revert previous commit on format on sfdx-project.json * removed max allocation and script file path from required, tested and worked * removed requestPromise required and trailing whitespace in poolCreateImpl * Fix for Scratch Orgs Not created with JWT Bearer Flow (#543) * Do not halt if the scratch org is created using JWT auth * Use scratchOrg Object Co-authored-by: azlam-abdulsalam <sfpowerscripts@dxscale> * Increment version * readded the correct changes and code that I missed when rebasing from main * reverted selected changes from rebase Co-authored-by: Genoud Magloire <magloiredjatio@gmail.com> Co-authored-by: Azlam <43767972+azlam-abdulsalam@users.noreply.github.com> Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale> Co-authored-by: Matt Simonis <matt.simonis@communitybrands.com>
Caitlyn-Mills
added a commit
that referenced
this pull request
Jul 13, 2021
* [fix] handle version number format in package dependency (#507) * update PMD to version 6.34.0. (#508) The default PMD version is now 6.34.0. The deprecated rules have been removed from `pmd-ruleset.xml` and have been replaced by the new rules equivalent. * Update versions * feat(source:pmd)!: output to stdout and add extra flags. (#516) * feat(source:pmd)!: output to stdout and add extra flags. BREAKING CHANGES: - The source:pmd command now output the result to stdout by default. The "-reportfile" flag can be used to restore the previous behaviour. - The command uses the same exit code as PMD. To always return 0 regardless of the analysis result, use the `--no-failonviolation` flag other changes: - --json flag now contains the analysis result. - add support for most of the PMD flags - deprecate `--report` in favour of `--reportfile` fixes #514 ``` This command is a wrapper around PMD ( downloads PMD for the first time) with some predefined defaults, such as ruleset, output format, output file. USAGE $ sfdx sfpowerkit:source:pmd [-d <directory> | --filelist <filepath>] [-r <string>] [-f <string>] [--report <filepath> | -o <filepath>] [--javahome <string>] [--failonviolation] [--minimumpriority <integer>] [--shortnames] [--showsuppressed] [--suppressmarker <string>] [--version <string>] [--json] [--loglevel trace|debug|info|warn|error|fatal|TRACE|DEBUG|INFO|WARN|ERROR|FATAL] OPTIONS -d, --directory=directory [default: Default project directory as mentioned in sfdx-project.json] Override this to set a different directory in the project folder -f, --format=format [default: text] [default: text] The format for the pmd output, Possible values are available at https://pmd.github.io/latest/pmd_userdocs_cli_reference.html#available-report-formats -o, --reportfile=reportfile [default: pmd-output] The path to where the output of the analysis should be written -r, --ruleset=ruleset [default: [sfpowerkit](https://github.com/Accenture/sfpowerkit/blob/main/resources/pmd-ruleset.xml)] The comma separated pmd ruleset that will be utilzied for analyzing the apex classes, Checkout https://pmd.github.io/latest/pmd_userdocs_making_rulesets.html to create your own ruleset --[no-]failonviolation [default: true] By default PMD exits with status 4 if violations are found. Disable this feature with -failOnViolation false to exit with 0 instead and just output the report. --filelist=filelist Path to file containing a comma delimited list of files to analyze. --javahome=javahome The command will try to locate the javahome path to execute PMD automatically, set this flag to override it to another javahome path --json format output as json --loglevel=(trace|debug|info|warn|error|fatal|TRACE|DEBUG|INFO|WARN|ERROR|FATAL) [default: warn] logging level for this command invocation --minimumpriority=minimumpriority Rule priority threshold; rules with lower priority than configured here won't be used. --report=report [default: pmd-output] DEPRECATED: use --reportfile instead. --[no-]shortnames Prints shortened filenames in the report. --[no-]showsuppressed Causes the suppressed rule violations to be added to the report. --suppressmarker=suppressmarker [default: NOPMD] Specifies the comment token that marks lines which PMD should ignore. --version=version [default: 6.34.0] [default: 6.34.0] The version of the pmd to be utilized for the analysis, this version will be downloaded to sfpowerkit's cache directory EXAMPLE $ sfdx sfpowerkit:source:pmd ``` * feat(source:pmd): allow rulesets from PMD classpath. This commit does not validate the location of the given rulesets, as they can be in JAR files in PMD's classpath. Other changes: - fix handling of --javahome - deprecate '--ruleset' in favor of '--rulesets' to align with PMD CLI options - display warning when deprecated flags are used - refactor 'run()' to reduce its complexity - if java can't be run, the exit code is 1 and the appropriate error message is displayed * chore: remove unused imports in pms.ts Co-authored-by: Azlam <43767972+azlam-abdulsalam@users.noreply.github.com> * Increment major version * Automatically authorize a user fetching an org from a pool (#519) * Saving Sfdx Auth Url if available * Fix npm audit issues * Add support for sfdxauthurl in fetch * Add an option to disable auto open * Fix not fetching when alias is not passed * Remove intermediate authFile from repo * Make fetched org act as scratch org * Add option to set defaultorg * Remove automatic opening Co-authored-by: Azlam <azlam.abdulsalam@accenture.com> Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale> * Increment minor version * fix:Issue #517 (#518) Fix reconcile on Activity fields Co-authored-by: Henry <henry88lay@gmail.com> * Increment patch version * Validate SFDX Auth URL (#523) * Fix Alias for user mode (#521) Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale> * Increment versions * [ci skip] Update new version id of the pool prerequisite package * fix:IIssue #524 Profile reconcile (#528) Happen when only one record returned for metadatatype. * Fix undhandled error when package is missing in packageAliases (#534) Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale> * Bug: Packages in mono repo getting installed (#533) * Bug: Packages in mono repo getting installed Packages in the same repo can be added as a dependency to another package, and it should be skipped as source code of these packages are available. A bug was causing all the packages to be installed if there was no existing packages in the scratch org * Fix Deepscan issues Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale> * Increment version * Update dependencies * Fixes #535 (#536) * Increment version * Update metadata coverage to 52 * Increment version * Fix for Scratch Orgs Not created with JWT Bearer Flow (#543) * Do not halt if the scratch org is created using JWT auth * Use scratchOrg Object Co-authored-by: azlam-abdulsalam <sfpowerscripts@dxscale> * Increment version * Issue/503 (#527) * Set Up Initial Files * commit changes removed both releasedefintion and sfdx-project schema json files. added the first converted tag mode config json schema * changes and additions corrected descriptions for tag mode schema added user mode schema * adjustments to the tag mode schema * changes done adjusted the schema to ensure the json pool configs are given types and refs * nested the schema pools * changes on array changed keyword from items to contains * changed pattern to format on ipaddress * added additionalProperties false line on users and poolusers * added required properties * pr amendments 1 added descriptions refined the required fields based on sfpowerkit doc. * removed required: pool as not needed when validated against json schema * added new file setting up the new json file to consoldate both user and tag mode before deleting others * removed these schemas as i have created a new one consolodating both * drafted and validated the new schema * Changes moved soPoolConfigSchema.ts to src/impl/pool/scratchorg/ introduced a code to make validate SO in poolCreateImpl] * fix:IIssue #524 Profile reconcile (#528) Happen when only one record returned for metadatatype. * Fix undhandled error when package is missing in packageAliases (#534) Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale> * Bug: Packages in mono repo getting installed (#533) * Bug: Packages in mono repo getting installed Packages in the same repo can be added as a dependency to another package, and it should be skipped as source code of these packages are available. A bug was causing all the packages to be installed if there was no existing packages in the scratch org * Fix Deepscan issues Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale> * Increment version * Update dependencies * Fixes #535 (#536) * Increment version * Update metadata coverage to 52 * Increment version * revert changes revert changes on poolCreateImpl on generateScratchOrgs line 369 to 397 revert changes on README in scratchorgpool package code to previous. revert previous commit on format on sfdx-project.json * removed max allocation and script file path from required, tested and worked * removed requestPromise required and trailing whitespace in poolCreateImpl * Fix for Scratch Orgs Not created with JWT Bearer Flow (#543) * Do not halt if the scratch org is created using JWT auth * Use scratchOrg Object Co-authored-by: azlam-abdulsalam <sfpowerscripts@dxscale> * Increment version * readded the correct changes and code that I missed when rebasing from main * reverted selected changes from rebase Co-authored-by: Genoud Magloire <magloiredjatio@gmail.com> Co-authored-by: Azlam <43767972+azlam-abdulsalam@users.noreply.github.com> Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale> Co-authored-by: Matt Simonis <matt.simonis@communitybrands.com> Co-authored-by: Mani <44075423+manisfdcsfdx@users.noreply.github.com> Co-authored-by: Rodolphe Blancho <rodolphe.blancho@gmail.com> Co-authored-by: Azlam <azlam.abdulsalam@accenture.com> Co-authored-by: Azlam <43767972+azlam-abdulsalam@users.noreply.github.com> Co-authored-by: Fabien Taillon <ftaillon@gmail.com> Co-authored-by: sfpowerscripts <sfpowerscripts@dxscale> Co-authored-by: Genoud Magloire <magloiredjatio@gmail.com> Co-authored-by: Henry <henry88lay@gmail.com> Co-authored-by: Alan Ly <36793262+aly76@users.noreply.github.com> Co-authored-by: Matt Simonis <matt.simonis@communitybrands.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages in the same repo can be added as a dependency to another package, and it should be skipped as source
code of these packages are available. A bug was causing all the packages to be installed if there was no existing packages in the scratch org