Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode incorrect VEX2 as valid instruction #195

Closed
nathanhjay opened this issue Oct 14, 2016 · 1 comment
Closed

Decode incorrect VEX2 as valid instruction #195

nathanhjay opened this issue Oct 14, 2016 · 1 comment
Assignees
@jdetter
Labels
blocked bug
Milestone
Release 10.0.0

Comments

@nathanhjay
Copy link
Contributor

The following two inputs produce an error according to all other decoders:
c5 a9 2c
c5 1d 2d 15 4b 9d 65 68

These instructions also suffer from the double printing mentioned in #193, but don't seem valid regardless.
Dyninst outputs:
cvttpd2pi (%rax),(%rax)
cvtpd2pi 0x68659d4b(%rip),0x68659d4b(%rip)
@nathanhjay nathanhjay added the bug label Oct 14, 2016
@jdetter
Copy link
Contributor

jdetter commented Nov 8, 2016 •
edited
Loading

Our output was wrong but it looks like those are two valid instructions, did objdump say they were invalid? Do they execute?

jdetter pushed a commit that referenced this issue Nov 22, 2016
Removed unreachable instructions. Moved all remaining VEX instruction…
2d7be7a 
… from SSE tables

	into proper VEX tables.

	Fixes #213 #199 #193 #195 #196
@jdetter jdetter mentioned this issue Nov 22, 2016
Merged
@jdetter jdetter added this to the Release 10.0.0 milestone Nov 22, 2016
@jdetter jdetter closed this as completed Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdetter jdetter

Labels
blocked bug
Projects
None yet
Milestone
Release 10.0.0
Development

No branches or pull requests
2 participants
@jdetter @nathanhjay